Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): support eslint.config.cjs and *.cjs extension with flat config #26637

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

benpsnyder
Copy link
Contributor

Fixes #26636

@benpsnyder benpsnyder requested a review from a team as a code owner June 22, 2024 18:23
Copy link

vercel bot commented Jun 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jun 22, 2024 7:55pm

@benpsnyder benpsnyder force-pushed the feat/support-cjs-flat-config-eslint branch 2 times, most recently from 65edf38 to d9480e0 Compare June 22, 2024 19:16
@benpsnyder benpsnyder changed the title feat(linter): support eslint.config.cjs with flat config feat(linter): support eslint.config.cjs and eslint.config.mjs with flat config Jun 22, 2024
@benpsnyder benpsnyder force-pushed the feat/support-cjs-flat-config-eslint branch from d9480e0 to 6444ef3 Compare June 22, 2024 19:24
@benpsnyder benpsnyder closed this Jun 22, 2024
@benpsnyder benpsnyder force-pushed the feat/support-cjs-flat-config-eslint branch from 6444ef3 to 963f753 Compare June 22, 2024 19:36
@benpsnyder benpsnyder reopened this Jun 22, 2024
@benpsnyder benpsnyder changed the title feat(linter): support eslint.config.cjs and eslint.config.mjs with flat config feat(linter): support eslint.config.cjs with flat config Jun 22, 2024
@benpsnyder benpsnyder changed the title feat(linter): support eslint.config.cjs with flat config feat(linter): support eslint.config.cjs and *.cjs extension with flat config Jun 22, 2024
@benpsnyder benpsnyder force-pushed the feat/support-cjs-flat-config-eslint branch from da8fb84 to 0c75d64 Compare June 22, 2024 19:53
@benpsnyder
Copy link
Contributor Author

@meeroslav my testing process was to build locally using nx run eslint:build then I used rsync on my node_modules rsync -av --delete /Volumes/SnyderDev/@benpsnyder/nx/build/packages/eslint/src/ /Volumes/SnyderDev/snyder/snyder-apps/node_modules/@nx/eslint/src/

I successfully was able to use my eslint.config.cjs file 👯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support .cjs file extension when using eslint flat config
1 participant