Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): add workspaces path if package path is not included #28824

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xiongemi
Copy link
Collaborator

@xiongemi xiongemi commented Nov 6, 2024

Current Behavior

  • when import to a path where is not in the workspaces, it currently just shows a warning. however, it will cause an error like "module not found" because there are packages not installed.

Expected Behavior

  • automatically add to the workspaces
    Screenshot 2024-11-08 at 12 58 42 AM

Related Issue(s)

Fixes #

@xiongemi xiongemi requested a review from a team as a code owner November 6, 2024 21:38
Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Nov 21, 2024 6:31pm

Copy link

nx-cloud bot commented Nov 6, 2024

@xiongemi xiongemi force-pushed the fix/not-import-uninstall-deps branch 9 times, most recently from e594984 to 0cf563d Compare November 8, 2024 15:41
@xiongemi xiongemi requested review from Coly010 and a team as code owners November 8, 2024 15:41
@xiongemi xiongemi force-pushed the fix/not-import-uninstall-deps branch 2 times, most recently from 356f0d7 to 86c4253 Compare November 8, 2024 17:54
packages/nx/src/command-line/import/import.ts Outdated Show resolved Hide resolved
packages/nx/src/command-line/import/import.ts Outdated Show resolved Hide resolved
packages/nx/src/command-line/import/import.ts Outdated Show resolved Hide resolved
@xiongemi xiongemi force-pushed the fix/not-import-uninstall-deps branch from d3c1811 to 9ded033 Compare November 18, 2024 01:29
@xiongemi xiongemi force-pushed the fix/not-import-uninstall-deps branch from 9ded033 to 7176929 Compare November 18, 2024 01:45
@xiongemi xiongemi force-pushed the fix/not-import-uninstall-deps branch from 7176929 to 20b7eb9 Compare November 20, 2024 02:31
@xiongemi xiongemi force-pushed the fix/not-import-uninstall-deps branch from 20b7eb9 to 7f1f74a Compare November 20, 2024 04:44
@xiongemi xiongemi force-pushed the fix/not-import-uninstall-deps branch from 7f1f74a to a1e76cb Compare November 20, 2024 04:55
@xiongemi xiongemi force-pushed the fix/not-import-uninstall-deps branch from a1e76cb to 8156a5d Compare November 20, 2024 05:49
@xiongemi xiongemi force-pushed the fix/not-import-uninstall-deps branch from 8156a5d to 65d614f Compare November 20, 2024 17:24
@xiongemi xiongemi force-pushed the fix/not-import-uninstall-deps branch from 65d614f to 342bfff Compare November 21, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants