Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat support bun pack #29426

Closed
wants to merge 2 commits into from
Closed

Conversation

Jordan-Hall
Copy link
Contributor

Current Behavior
Before release last night/today of bun 1.1.27 bun pm pack didn't exists so we fell upon npm pack.

Expected Behavior
If bun 1.1.27 or greater we use bun pm pack otherwise we revert to npm pack

https://x.com/bunjavascript/status/1832386689182122092

cc: @jaysoo

@Jordan-Hall Jordan-Hall requested a review from a team as a code owner December 19, 2024 15:47
Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Dec 19, 2024 3:57pm

Copy link

nx-cloud bot commented Dec 19, 2024

View your CI Pipeline Execution ↗ for commit 524a878.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 43m 35s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 1m 40s View ↗
nx-cloud record -- nx format:check --base=39b8a... ✅ Succeeded 2m 4s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 27s View ↗
nx documentation --no-dte ✅ Succeeded 1m 13s View ↗
nx affected -t e2e-macos-local --parallel=1 --b... ✅ Succeeded 24m 19s View ↗

☁️ Nx Cloud last updated this comment at 2024-12-19 16:41:50 UTC

@leosvelperez
Copy link
Member

Thanks for the contribution!

Unfortunately, bun pm pack creates a tarball of the current workspace (similar to yarn), which is not what the current packageRegistryPack helper function is intended to do. That helper function is intended to produce a tarball of packages retrieved from the registry.

I'm closing this since the changes wouldn't produce the desired result.

Copy link

github-actions bot commented Feb 4, 2025

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants