Skip to content

fix(core): update yarn-parser to handle yarn v4 syntax for root workspace package#29452

Merged
FrozenPandaz merged 1 commit intonrwl:masterfrom
a88zach:29451
Jan 21, 2025
Merged

fix(core): update yarn-parser to handle yarn v4 syntax for root workspace package#29452
FrozenPandaz merged 1 commit intonrwl:masterfrom
a88zach:29451

Conversation

@a88zach
Copy link
Copy Markdown
Contributor

@a88zach a88zach commented Dec 20, 2024

Current Behavior

The root workspace package is not generated correctly when using Yarn v4

Expected Behavior

yarn.lock should be created correctly

Related Issue(s)

Fixes #29451

@a88zach a88zach requested review from a team and meeroslav as code owners December 20, 2024 21:12
@a88zach a88zach requested a review from AgentEnder December 20, 2024 21:12
@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Dec 20, 2024 9:14pm

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Dec 20, 2024

View your CI Pipeline Execution ↗ for commit 50ce2fe.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 32m 37s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 1m 2s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base=d7ffb... ✅ Succeeded 25s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 23s View ↗
nx documentation --no-dte ✅ Succeeded 1m 8s View ↗

☁️ Nx Cloud last updated this comment at 2024-12-20 21:54:18 UTC

@FrozenPandaz FrozenPandaz merged commit 3c98a1c into nrwl:master Jan 21, 2025
FrozenPandaz pushed a commit that referenced this pull request Jan 22, 2025
…pace package (#29452)

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
The root workspace package is not generated correctly when using Yarn v4

## Expected Behavior
yarn.lock should be created correctly

## Related Issue(s)

Fixes #29451

(cherry picked from commit 3c98a1c)
FrozenPandaz pushed a commit that referenced this pull request Jan 22, 2025
…pace package (#29452)

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
The root workspace package is not generated correctly when using Yarn v4

## Expected Behavior
yarn.lock should be created correctly

## Related Issue(s)

Fixes #29451

(cherry picked from commit 3c98a1c)
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jan 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Root worksapce package not generated correctly for Yarn v4

3 participants