fix(js): identify correct circular dependecies #29759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit e74160c.
☁️ Nx Cloud last updated this comment at |
xiongemi
force-pushed
the
feature/nxc-1380-nx-release-increments-version-inconsistently
branch
from
19136bf to
e74160c
Compare
JamesHenry
approved these changes
Feb 19, 2025
JamesHenry
deleted the
feature/nxc-1380-nx-release-increments-version-inconsistently
branch
FrozenPandaz
pushed a commit
that referenced
this pull request
Feb 20, 2025
(cherry picked from commit 1047991)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
currently, when detecting circular dep in release, it tests
dependentProject.target === projectName, which adds all projects as circular deps. because filter allDependentProjects islocalPackageDependency.target === projectName, sodependentProject.target === projectNameis always trueExpected Behavior
correct the logic of detecting circular deps, it should test
Related Issue(s)
Fixes #28336