Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): allow publishable library to run release command #29775

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xiongemi
Copy link
Collaborator

@xiongemi xiongemi commented Jan 28, 2025

Current Behavior

  • there is no option fallbackCurrentVersionResolver: 'disk',
  • can't run release for newly created publishable libraries

Expected Behavior

  • move code to add release for publishable libraries into its own file to be reused by other stacks
  • add fallbackCurrentVersionResolver: 'disk', to project's release.version. generatorOptions

Related Issue(s)

Fixes #29723

@xiongemi xiongemi requested review from a team as code owners January 28, 2025 06:27
Copy link

vercel bot commented Jan 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2025 3:59am

Copy link

nx-cloud bot commented Jan 28, 2025

View your CI Pipeline Execution ↗ for commit a71555f.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 39m 26s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 51s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base=10c14... ✅ Succeeded 25s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 24s View ↗
nx documentation --no-dte ✅ Succeeded 42s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-30 04:42:39 UTC

@xiongemi xiongemi force-pushed the feature/nxc-1383-release-command-does-not-work-for-nxjslib-publishable branch 2 times, most recently from dcfe278 to ce3fe9e Compare January 28, 2025 07:08
@xiongemi xiongemi force-pushed the feature/nxc-1383-release-command-does-not-work-for-nxjslib-publishable branch 2 times, most recently from b87f905 to dac0831 Compare January 30, 2025 03:11
@xiongemi xiongemi force-pushed the feature/nxc-1383-release-command-does-not-work-for-nxjslib-publishable branch from dac0831 to a71555f Compare January 30, 2025 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release group "__default__" matches no projects. Please ensure all release groups match at least one project
1 participant