Check if valgrind is operational

nsauzede · Oct 17, 2023 · 4b6aec6 · 4b6aec6
1 parent 5c4ae7e
commit 4b6aec6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/.github/workflows/vade.yml b/.github/workflows/vade.yml
@@ -14,6 +14,6 @@ jobs:
     steps:
       - uses: actions/checkout@v3
       - name: Install dependencies
-        run: sudo apt install --quiet -y make gcc python3 bash valgrind nasm
+        run: sudo apt update && sudo apt install --quiet -y make gcc python3 bash valgrind nasm
       - name: Build and test
         run: bin/vade clean test
diff --git a/Makefile b/Makefile
@@ -62,7 +62,8 @@ ifeq ($(CC),$(CLANG))
 VALGRIND:=
 endif
 
-ifeq (, $(shell which $(VALGRIND) 2>/dev/null))
+# Check if valgrind is operational (eg: not missing debuginfo etc..)
+ifneq (0, $(shell $(VALGRIND) /bin/false 2>/dev/null ; echo $?))
 #$(error "NOT HAVE VALGRIND ($(VALGRIND))")
 RUN:=
 RUNTEST:=RUN