-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: adjust upload-state
command to upload key-value pairs instead of full MPT traversal
#3845
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3845 +/- ##
==========================================
+ Coverage 82.53% 82.56% +0.02%
==========================================
Files 342 342
Lines 47891 47887 -4
==========================================
+ Hits 39527 39537 +10
+ Misses 6730 6708 -22
- Partials 1634 1642 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
So, where is the real description of the problem? |
a6a7542
to
96caa81
Compare
upload-state
commandupload-state
command to upload key-value pairs instead of full MPT traversal
96caa81
to
5ca2c6b
Compare
Size/speed difference with the old one? |
5ca2c6b
to
5e19408
Compare
The last state object was skipped during uploading. Calculation for logging latest uploaded state adjusted. Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
5e19408
to
131fcd7
Compare
Current:
previous (full mpt):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM.
131fcd7
to
f60feef
Compare
This is unexpectedly slow and differs from previous two results. At the same time I'm not sure if we can optimize full MPT traversal process because we anyway need to traverse the whole tree unwrapping all hash nodes on the way. Another point I'd like to mention here is that we still have #3103. This issue does not directly affect the |
Ref. #3782