core, util: attach stateroot witness to NeoFS state objects #4099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4099 +/- ##
==========================================
- Coverage 83.50% 83.31% -0.20%
==========================================
Files 353 353
Lines 42827 42925 +98
==========================================
Hits 35764 35764
- Misses 5305 5401 +96
- Partials 1758 1760 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
I'll test this code on real network once we finalize the PR. |
AnnaShaleva
force-pushed
the
witnessed-root
branch
3 times, most recently
from
e0fdcb0 to
a26d6a8
Compare
AnnaShaleva
force-pushed
the
witnessed-root
branch
from
a26d6a8 to
3d7e28d
Compare
Member
Author
|
|
AnnaShaleva
force-pushed
the
witnessed-root
branch
3 times, most recently
from
8aacb96 to
c902752
Compare
AnnaShaleva
force-pushed
the
witnessed-root
branch
from
c902752 to
285b09f
Compare
A part of #4049. Signed-off-by: Anna Shaleva <[email protected]>
Oracle, StateRoot and Notary services should properly react to state jump (either occured after state reset or after statesync finalization). Otherwise, these services use an out-of-date roles information retrieved from the previous node state. Signed-off-by: Anna Shaleva <[email protected]>
A part of #4049. 1. Check the stateroot witness. 2. Ensure witness' public keys match block's validators at the state sync height. Signed-off-by: Anna Shaleva <[email protected]>
This callback is set when module is not active yet, no locking required. Signed-off-by: Anna Shaleva <[email protected]>
(*Module).syncStage is a subject of change, it may be updated by statechanging Module's callbacks concurrently. Signed-off-by: Anna Shaleva <[email protected]>
AnnaShaleva
force-pushed
the
witnessed-root
branch
2 times, most recently
from
28b9f94 to
24a3003
Compare
Signed-off-by: Anna Shaleva <[email protected]>
AnnaShaleva
force-pushed
the
witnessed-root
branch
from
24a3003 to
b340085
Compare
roman-khimov
approved these changes
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #4049.
As an alternative, we may consider attaching a full serialized stateroot instead of just witness (right now stateroot version is missing from the state object which may be a problem in future if stateroot version will be changed).