producer: Integrate context.Context with publishing #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mreiferson
requested changes
Sep 1, 2024
| c.mtx.Unlock() | ||
| return ctx.Err() | ||
| default: | ||
| _, err := cmd.WriteTo(c) |
There was a problem hiding this comment.
I think we're shadowing err here and it won't be correct on line 323
| // keep the connection alive if related to context timeout | ||
| // need to do some stuff that's in Producer.popTransaction here | ||
| w.transactions = w.transactions[1:] | ||
| t.Error = err |
There was a problem hiding this comment.
I don't love this code we've copied in to this context-specific edge case, can't we consolidate this in to popTransaction? Do we need to define a context-specific error code for the protocol?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets out to resolve #360 with the integration of context.Context in the
nsq.Producer. In order to maintain backwards compatibility, new methods were added that have names with the suffixWithContext. These new methods mostly correspond to those that a client would use to publish messages and they adhere to context timeouts/deadlines. Once the deadline has been reached, an error will be returned to the client and the givenProducerTransactionwill be dropped/not published, all while keeping the connection tonsqdalive.An overview of the new methods added are below:
nsq.Conn
nsq.Producer
The idea here being that these
WithContextmethods would essentially replace the existing ones eventually, which would be a breaking/major version change forgo-nsq.