-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ipprefix via argument #497
base: master
Are you sure you want to change the base?
Conversation
58fb27d
to
f0ebc86
Compare
Is that ipprefix parameter supported by any dyndns service and any dyndns client already? |
f0ebc86
to
2e4da61
Compare
to be honest, not that I know of. I used dynv6 before, but they are down now, and they had their own - but similar API. For me at least, I wanted that because passing the |
2e4da61
to
1b92dfd
Compare
If you want I can adjust the behavior or rename the parameter. The advantage of the extra parameter is that it keeps the api still compatible, as the calls still work without it as before. |
Any consideration? Or alternative suggestion? I mean, this is a real-world problem :) |
I didn't do any related investigations yet, but at least I started working on the software and site again - primarily due to #505 (which is already half-done on the prod system). For this PR it would be great if you could rebase it on current master branch, so that the github actions based tests will run (travis-ci is defunct here since long). |
4b8af0a
to
73bb0ce
Compare
rebased on |
Any updates on this @ThomasWaldmann? I can confirm that this is a real-life issue: Deutsche Telekom assigns customers both a /64 and a /56 prefix by default (two totally different subnets indeed, i.e. the /64 subnet is not within the /56 subnet). AVM Fritz!Box routers will then use the given /64 prefix just for the router and use a randomly chosen /64 subnet within the given /56 subnet for all clients in the network. That's why we can't derive the IPv6 addresses of related hosts using the routers IPv6 address - they are in different subnets. It just took me some time to notice that the prefixes don't match 🙈 By googling for "ip6lanprefix" (as in how AVM calls it) one finds multiple other dynamic DNS services (e.g. dynv6.com, dnshome.de, strato.com, do.de) with similar API parameters, however, they are all named differently. Calling it "ipprefix" makes sense IMO considering it works for both IPv4 and IPv6 (even though I doubt than one would ever use it for IPv4...). Would be great if we can get this to prod ❤️ |
73bb0ce
to
b212395
Compare
Happy second birthday 🎉 |
Allow an extra argument
ipprefix
for both ipv4 and ipv6 to pass a separate prefix, like often for IPv6 connections where one gets a main ipv6 for the router and a subnet for the internal network.Passing the ipprefix will also override the default netmask from the config.
Fixes #353