Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log output #810

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
+84 −40
Open

Fix log output #810

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3ca902c
update stdout for correct content piping
bryanvaz Oct 15, 2024
1ef9db6
update to use secondary logger for output cells with no extra newline
bryanvaz Oct 18, 2024
4dfb47f
quickfix for edge case when used as a library
bryanvaz Oct 18, 2024
2ec6897
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 18, 2024
f9000b0
quickfix for precommit
bryanvaz Oct 18, 2024
abf1112
remove docstring to appease precommit
bryanvaz Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
quickfix for precommit
@bryanvaz
bryanvaz authored Oct 18, 2024
commit f9000b05622409b506dc5fa5d58baa9be28a9e88
8 changes: 4 additions & 4 deletions papermill/log.py
View file
Original file line number Diff line number Diff line change
@@ -23,13 +23,13 @@ def emit(self, record):
self.handleError(record)


def _reconfigure_notebook_logger(l: logging.Logger):
l.handlers = []
def _reconfigure_notebook_logger(log: logging.Logger):
log.handlers = []
custom_handler = NbOutputStreamHandler()
l.addHandler(custom_handler)
log.addHandler(custom_handler)
formatter = logging.Formatter('%(message)s')
custom_handler.setFormatter(formatter)
l.propagate = False
log.propagate = False


_reconfigure_notebook_logger(notebook_logger)