fix(cargo): broken repo url for ntex-bytes #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
reviewed
Apr 2, 2024
| @@ -4,7 +4,7 @@ version = "0.1.24" | |||
| authors = ["Nikolay Kim <[email protected]>", "Carl Lerche <[email protected]>"] | |||
| description = "Types and traits for working with bytes (bytes crate fork)" | |||
| documentation = "https://docs.rs/ntex-bytes" | |||
| repository = "https://github.com/ntex-rs" | |||
| repository = "https://github.com/ntex-rs/ntex.git" | |||
There was a problem hiding this comment.
Also .git is unnecessary, cargo documentation does not use it for github URL in their example and this is what most crates put into repository. So it could be "https://github.com/ntex-rs/ntex".
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! While scranning the top 20k crates on crates.io (M4SS-Code/cargo-goggles#11) we've encountered an error with
ntex-bytesbecause it declares a broken repository URL. This PR fixes it by using the same repository URL as the other crates inside the workspace.