validator accepts predict_oof as argument #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`validator` was the only function in `validator.py` to not get `predict_oof` as an argument, even though it was already listed as an argument in the function's docstring. This PR adds `predict_oof` as an optional arg to the function header and passes it as an argument to `validator_iterator` inside the function body.
Codecov Report
@@ Coverage Diff @@
## master #49 +/- ##
=========================================
Coverage ? 94.49%
=========================================
Files ? 25
Lines ? 1434
Branches ? 192
=========================================
Hits ? 1355
Misses ? 48
Partials ? 31
Continue to review full report at Codecov.
|
hf-lopes
previously approved these changes
Apr 25, 2019
Done |
caique-lima
previously approved these changes
Apr 30, 2019
caique-lima
added
the
ready-to-merge
caique-lima
removed
the
ready-to-merge
caique-lima
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Background context
validatorwas the only function invalidator.pyto not getpredict_oofas an argument, even though it was already listed as an argument in the function's docstring.Description of the changes proposed in the pull request
This PR adds
predict_oofas an optional arg to the function header and passes it as an argument tovalidator_iteratorinside the function body.