Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - runconfigs v2 #3285

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

WIP - runconfigs v2 #3285

wants to merge 27 commits into from

Conversation

alishakawaguchi
Copy link
Contributor

No description provided.

@alishakawaguchi alishakawaguchi self-assigned this Feb 20, 2025
Copy link

vercel bot commented Feb 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
neosync-docs ⬜️ Ignored (Inspect) Visit Preview Feb 28, 2025 1:26am

Copy link

github-actions bot commented Feb 20, 2025

Benchstat Geomean Results

0.01% sec/op, -0.01% B/op, 0.00% allocs/op

Benchstat results
                                   │ main-benchmark.txt │       branch-benchmark.txt        │
                                   │       sec/op       │   sec/op     vs base              │
CleanPostgresType-4                         42.63n ± 4%   42.75n ± 2%       ~ (p=0.288 n=6)
Runner_Single-4                             7.713µ ± 5%   7.655µ ± 4%       ~ (p=0.180 n=6)
GenerateBool-4                              11.45n ± 1%   11.35n ± 1%  -0.87% (p=0.028 n=6)
GenerateBusinessName-4                      285.4n ± 0%   287.4n ± 7%       ~ (p=1.000 n=6)
GenerateCardNumber-4                        28.41n ± 1%   28.41n ± 0%       ~ (p=1.000 n=6)
GenerateCategorical-4                       104.1n ± 2%   101.4n ± 1%  -2.55% (p=0.002 n=6)
GenerateCity-4                              173.7n ± 0%   174.2n ± 1%       ~ (p=0.429 n=6)
GenerateCountry-4                           105.2n ± 1%   108.9n ± 1%  +3.52% (p=0.002 n=6)
GenerateEmail-4                             1.346µ ± 0%   1.341µ ± 0%  -0.41% (p=0.004 n=6)
GenerateFirstName-4                         203.9n ± 0%   200.6n ± 0%  -1.62% (p=0.002 n=6)
GenerateFloat64-4                           28.73n ± 1%   28.50n ± 0%  -0.80% (p=0.002 n=6)
GenerateFullAddress-4                       1.429µ ± 3%   1.442µ ± 1%       ~ (p=0.180 n=6)
GenerateFullName-4                          1.222µ ± 1%   1.228µ ± 2%       ~ (p=0.054 n=6)
GenerateGender-4                            41.42n ± 0%   41.68n ± 1%  +0.62% (p=0.004 n=6)
GenerateInt64-4                             28.41n ± 2%   27.87n ± 0%  -1.90% (p=0.002 n=6)
GenerateInt64PhoneNumber-4                  51.46n ± 2%   51.58n ± 2%       ~ (p=0.372 n=6)
GenerateInternationalPhoneNumber-4          175.8n ± 1%   176.7n ± 1%  +0.51% (p=0.011 n=6)
GenerateIpAddress-4                         569.3n ± 0%   561.1n ± 1%  -1.43% (p=0.002 n=6)
GenerateLastName-4                          187.4n ± 1%   193.7n ± 0%  +3.33% (p=0.002 n=6)
GenerateRandomString-4                      985.6n ± 1%   979.9n ± 4%       ~ (p=0.193 n=6)
GenerateSHA256Hash-4                        1.016µ ± 0%   1.009µ ± 1%  -0.79% (p=0.004 n=6)
GenerateSSN-4                               305.8n ± 1%   306.6n ± 1%       ~ (p=0.182 n=6)
GenerateState-4                             105.2n ± 2%   105.2n ± 0%       ~ (p=0.959 n=6)
GenerateStreetAddress-4                     204.0n ± 1%   205.2n ± 1%  +0.59% (p=0.015 n=6)
GenerateStringPhoneNumber-4                 179.3n ± 0%   174.8n ± 0%  -2.48% (p=0.002 n=6)
GenerateUnixTimestamp-4                     77.13n ± 1%   77.34n ± 1%       ~ (p=0.310 n=6)
GenerateUsername-4                          351.5n ± 0%   362.7n ± 0%  +3.20% (p=0.002 n=6)
GenerateUTCTimestamp-4                      104.2n ± 1%   104.1n ± 0%       ~ (p=0.316 n=6)
GenerateUUID-4                              734.0n ± 0%   743.1n ± 1%  +1.25% (p=0.002 n=6)
GenerateZipcode-4                           105.2n ± 2%   106.0n ± 0%       ~ (p=0.054 n=6)
TransformCharacterScramble-4                171.8n ± 1%   174.2n ± 1%  +1.43% (p=0.002 n=6)
TransformE164PhoneNumber-4                  180.2n ± 3%   178.5n ± 1%  -0.94% (p=0.009 n=6)
TransformEmail-4                            1.798µ ± 2%   1.789µ ± 0%  -0.53% (p=0.002 n=6)
TransformFirstName-4                        233.9n ± 0%   233.6n ± 1%       ~ (p=0.387 n=6)
TransformFloat64-4                          110.8n ± 4%   110.0n ± 2%       ~ (p=0.329 n=6)
TransformFullName-4                         1.235µ ± 2%   1.246µ ± 1%       ~ (p=0.100 n=6)
TransformInt64-4                            33.74n ± 1%   33.14n ± 0%  -1.79% (p=0.002 n=6)
TransformInt64PhoneNumber-4                 57.84n ± 2%   58.14n ± 0%       ~ (p=0.071 n=6)
TransformLastName-4                         191.6n ± 0%   196.7n ± 1%  +2.66% (p=0.002 n=6)
TransformString-4                           1.022µ ± 0%   1.024µ ± 1%       ~ (p=0.621 n=6)
TransformStringPhoneNumber-4                211.0n ± 2%   204.7n ± 0%  -2.99% (p=0.002 n=6)
TransformUuid-4                             36.54n ± 1%   36.26n ± 1%       ~ (p=0.052 n=6)
geomean                                     194.0n        194.0n       +0.01%

                                   │ main-benchmark.txt │         branch-benchmark.txt         │
                                   │        B/op        │     B/op      vs base                │
CleanPostgresType-4                        0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=6) ¹
Runner_Single-4                          2.312Ki ± 1%     2.303Ki ± 1%       ~ (p=0.258 n=6)
GenerateBool-4                             0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateBusinessName-4                     304.0 ± 0%       304.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCardNumber-4                       8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCategorical-4                      64.00 ± 0%       64.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCity-4                             160.0 ± 0%       160.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCountry-4                          24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateEmail-4                            385.0 ± 0%       385.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFirstName-4                        208.0 ± 0%       208.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFloat64-4                          8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullAddress-4                      512.0 ± 0%       512.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullName-4                         418.0 ± 0%       418.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateGender-4                           16.00 ± 0%       16.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64-4                            7.000 ± 0%       7.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64PhoneNumber-4                 8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInternationalPhoneNumber-4         40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateIpAddress-4                        31.00 ± 0%       31.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateLastName-4                         176.0 ± 0%       176.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateRandomString-4                     186.0 ± 0%       186.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSHA256Hash-4                       288.0 ± 0%       288.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSSN-4                              46.00 ± 0%       46.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateState-4                            24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStreetAddress-4                    240.0 ± 0%       240.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStringPhoneNumber-4                40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUnixTimestamp-4                    8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUsername-4                         205.0 ± 0%       205.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUTCTimestamp-4                     24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUUID-4                             80.00 ± 0%       80.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateZipcode-4                          24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformCharacterScramble-4               40.00 ± 3%       40.00 ± 3%       ~ (p=1.000 n=6)
TransformE164PhoneNumber-4                 40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformEmail-4                           489.0 ± 0%       489.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformFirstName-4                       224.0 ± 0%       224.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformFloat64-4                         88.00 ± 0%       88.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformFullName-4                        418.0 ± 0%       418.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64-4                           8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64PhoneNumber-4                8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformLastName-4                        176.0 ± 0%       176.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformString-4                          202.0 ± 0%       202.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformStringPhoneNumber-4               56.00 ± 0%       56.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformUuid-4                            16.00 ± 0%       16.00 ± 0%       ~ (p=1.000 n=6) ¹
geomean                                               ²                 -0.01%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                                   │ main-benchmark.txt │        branch-benchmark.txt        │
                                   │     allocs/op      │ allocs/op   vs base                │
CleanPostgresType-4                        0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
Runner_Single-4                            24.00 ± 0%     24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateBool-4                             0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateBusinessName-4                     2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCardNumber-4                       1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCategorical-4                      2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCity-4                             2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCountry-4                          2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateEmail-4                            8.000 ± 0%     8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFirstName-4                        2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFloat64-4                          1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullAddress-4                      10.00 ± 0%     10.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullName-4                         6.000 ± 0%     6.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateGender-4                           1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64-4                            0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64PhoneNumber-4                 1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInternationalPhoneNumber-4         3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateIpAddress-4                        2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateLastName-4                         2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateRandomString-4                     3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSHA256Hash-4                       7.000 ± 0%     7.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSSN-4                              3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateState-4                            2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStreetAddress-4                    2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStringPhoneNumber-4                3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUnixTimestamp-4                    1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUsername-4                         6.000 ± 0%     6.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUTCTimestamp-4                     1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUUID-4                             3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateZipcode-4                          2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformCharacterScramble-4               2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformE164PhoneNumber-4                 3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformEmail-4                           14.00 ± 0%     14.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformFirstName-4                       3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformFloat64-4                         3.000 ± 0%     3.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformFullName-4                        6.000 ± 0%     6.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64-4                           1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64PhoneNumber-4                1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformLastName-4                        2.000 ± 0%     2.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformString-4                          4.000 ± 0%     4.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformStringPhoneNumber-4               4.000 ± 0%     4.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformUuid-4                            1.000 ± 0%     1.000 ± 0%       ~ (p=1.000 n=6) ¹
geomean                                               ²               +0.00%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 56.66667% with 390 lines in your changes missing coverage. Please review.

Project coverage is 22.70%. Comparing base (b149252) to head (8ef0022).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
worker/pkg/select-query-builder/querybuilder.go 0.00% 269 Missing ⚠️
internal/runconfigs/runconfigs.go 77.04% 36 Missing and 6 partials ⚠️
internal/benthos/benthos-builder/builders/sql.go 10.52% 17 Missing ⚠️
internal/runconfigs/builder.go 94.80% 12 Missing and 4 partials ⚠️
worker/pkg/select-query-builder/subset.go 0.00% 15 Missing ⚠️
...ernal/benthos/benthos-builder/builders/dynamodb.go 0.00% 9 Missing ⚠️
...ternal/benthos/benthos-builder/builders/mongodb.go 0.00% 9 Missing ⚠️
cli/internal/cmds/neosync/sync/sync.go 0.00% 2 Missing ⚠️
...ternal/benthos/benthos-builder/generate-benthos.go 0.00% 2 Missing ⚠️
cli/internal/cmds/neosync/sync/util.go 0.00% 1 Missing ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3285      +/-   ##
==========================================
- Coverage   24.48%   22.70%   -1.79%     
==========================================
  Files         391      392       +1     
  Lines       45224    45249      +25     
==========================================
- Hits        11072    10272     -800     
- Misses      33045    33949     +904     
+ Partials     1107     1028      -79     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant