Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor of Refresh & Recovery procedures #158

Merged
merged 17 commits into from
Sep 15, 2023
Merged

Commits on Sep 4, 2023

  1. Remove Pvss type alias

    cygnusv committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    59aacbb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    372f5d7 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2023

  1. Configuration menu
    Copy the full SHA
    5c141e1 View commit details
    Browse the repository at this point in the history
  2. Rename random polynomial function for refresh & recovery

    Technically, this helper function creates a random polynomial where the `root` parameter is a root of the polynomial, so `make_random_polynomial_with_root` is a better name.
    cygnusv committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    b6d1f41 View commit details
    Browse the repository at this point in the history
  3. Helper functions to prepare share updates for both recovery & refresh

    There was no function for the refresh case, and since it's very similar to the recovery case, we define here a common method for both (`prepare_share_updates_with_root`)
    cygnusv committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    39ec865 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2d30abf View commit details
    Browse the repository at this point in the history
  5. Clarify how the degree in make_random_polynomial_with_root is defined

    The concept of "threshold" doesn't belong to the abstraction level of polynomials, which actually deal with degrees. For the record, it's always the case that `threshold == degree + 1`.
    cygnusv committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    6115976 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b65798f View commit details
    Browse the repository at this point in the history
  7. Simplify simple recovery test

    Test using secret reconstruction directly, rather than via ciphertext decryption.
    cygnusv committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    7c26487 View commit details
    Browse the repository at this point in the history
  8. Simplify share refresh test

    cygnusv committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    d732196 View commit details
    Browse the repository at this point in the history
  9. Remove incorrect share refresh utility functions

    These functions assumed access to an update polynomial, but we're actually using several distributed polynomials (one for each participant) and we only have access to their evaluated points.
    
    Note that the commits before did the preparation to remove this now.
    cygnusv committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    ce675a6 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. Almost fix test_dkg_simple_tdec_share_recovery

    Updates for shares were not applied correctly (see diff in  L418-423). For the moment, we're recovering the same domain point since it facilitates debugging, but in the next commit I'll restore the test so there's a new validator, with a random domain point.
    cygnusv committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    8ef9e7f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ab5e58c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8407f78 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. TODOs and comments

    cygnusv committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    3b3ff48 View commit details
    Browse the repository at this point in the history
  2. Disable affected benchmarks

    * Removed benchmark for random polynomial with root (not much value as it's essentially benchmarking arkworks)
    * Commented recovery & refresh benchmarks for when #162 is solved
    cygnusv committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    29101b1 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. Linting and stuff

    cygnusv committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    1704f86 View commit details
    Browse the repository at this point in the history