Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor DKG parameters into a DkgParams #169

Merged
merged 7 commits into from
Jan 23, 2024
Merged

Refactor DKG parameters into a DkgParams #169

merged 7 commits into from
Jan 23, 2024

Conversation

piotr-roslaniec
Copy link

@piotr-roslaniec piotr-roslaniec commented Jan 18, 2024 •
edited
Loading

Type of PR:

  • Refactor

Required reviews:

  • 1

What this does:

  • Refactors DKG parameters usage and validation into DkgParams
  • Uses test_case crate in tests to duplicate test scenarios
  • Refactors shared test utils and variables into ferveo::test_common module
  • Replaces some panics with proper error handling and error types
  • Fixes some outstanding TODOs

Notes for reviewers:

  • This PR contains no API changes. I opted to address these changes here to avoid bundling them with PRs that contain functional changes, making it easier to review them.
  • Reviewing commit by commit should be easier
  • Based on Assorted chores #166 - Please review it first

@piotr-roslaniec piotr-roslaniec changed the title feat(ferveo): derive eq in DkgPublicKey Refactor DKG parameters into a DkgParams Jan 18, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2024 •
edited
Loading

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (7350d91) 78.10% compared to head (feee2f3) 77.76%.

❗ Current head feee2f3 differs from pull request most recent head aebaab3. Consider uploading reports for the commit aebaab3 to get more accurate results

Files Patch % Lines
ferveo/src/bindings_python.rs 68.18% 14 Missing ⚠️
ferveo/src/api.rs 96.95% 5 Missing ⚠️
ferveo/src/bindings_wasm.rs 0.00% 3 Missing ⚠️
ferveo/src/dkg.rs 94.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
- Coverage   78.10%   77.76%   -0.34%     
==========================================
  Files          23       24       +1     
  Lines        5097     5105       +8     
==========================================
- Hits         3981     3970      -11     
- Misses       1116     1135      +19

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@piotr-roslaniec piotr-roslaniec marked this pull request as ready for review January 19, 2024 12:59
@piotr-roslaniec piotr-roslaniec mentioned this pull request Jan 22, 2024
Merged
manumonti
manumonti approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@manumonti manumonti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely I'm not an expert on this field, but it makes sense what I see here.

@piotr-roslaniec piotr-roslaniec merged commit 802e712 into nucypher:main Jan 23, 2024
10 checks passed
@piotr-roslaniec piotr-roslaniec deleted the dkg-params-refactor branch January 23, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manumonti manumonti manumonti approved these changes

@KPrasch KPrasch Awaiting requested review from KPrasch

@cygnusv cygnusv Awaiting requested review from cygnusv

@theref theref Awaiting requested review from theref

@derekpierre derekpierre Awaiting requested review from derekpierre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piotr-roslaniec @codecov-commenter @manumonti