Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported Python versions #171

Merged
merged 10 commits into from
Jan 23, 2024

Conversation

piotr-roslaniec
Copy link

@piotr-roslaniec piotr-roslaniec commented Jan 22, 2024

Type of PR:

  • Other

Required reviews:

  • 1

Issues fixed/closed:

Notes for reviewers:

@codecov-commenter
Copy link

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (7350d91) 78.10% compared to head (79b8f3d) 77.76%.

Files Patch % Lines
ferveo/src/bindings_python.rs 68.18% 14 Missing ⚠️
ferveo/src/api.rs 96.95% 5 Missing ⚠️
ferveo/src/bindings_wasm.rs 0.00% 3 Missing ⚠️
ferveo/src/dkg.rs 94.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
- Coverage   78.10%   77.76%   -0.35%     
==========================================
  Files          23       24       +1     
  Lines        5097     5104       +7     
==========================================
- Hits         3981     3969      -12     
- Misses       1116     1135      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@piotr-roslaniec piotr-roslaniec marked this pull request as ready for review January 22, 2024 15:16
Copy link
Member

@manumonti manumonti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👌

@piotr-roslaniec piotr-roslaniec merged commit de9cf36 into nucypher:main Jan 23, 2024
11 checks passed
@piotr-roslaniec piotr-roslaniec deleted the python-versions branch January 23, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants