Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yet another batch of improvements for Coordinator #107

Merged
merged 16 commits into from
Aug 27, 2023
Merged

Yet another batch of improvements for Coordinator #107

merged 16 commits into from
Aug 27, 2023

Commits on Aug 25, 2023

  1. API for bidirectional mapping between public keys and successful rituals

    @cygnusv
    cygnusv committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    8d2d327 View commit details
    Browse the repository at this point in the history

  2. Invalidate stored public key if ritual fails 

    Closes nucypher#78
    @cygnusv
    cygnusv committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    b7f04c2 View commit details
    Browse the repository at this point in the history

  3. Store threshold in ritual struct, but not allow initiator to set it f… 

    …or the moment

We currently define it as the lowest value that produces a threshold set that's strictly greater than the 50% of the overall size.
See nucypher/nucypher#3095
    @cygnusv
    cygnusv committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    5f81380 View commit details
    Browse the repository at this point in the history

  4. Define minimum ritual duration as 24 hours. 

    See nucypher#106
    @cygnusv
    cygnusv committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    57cfa1c View commit details
    Browse the repository at this point in the history

  5. Additional tests for coordinator

    @cygnusv
    cygnusv committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    675219d View commit details
    Browse the repository at this point in the history

  6. It's FlatRate, not FlateRate....

    @cygnusv
    cygnusv committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    c4848ae View commit details
    Browse the repository at this point in the history

  7. Simplify deployment by Coordinator extending from FlatRateFeeModel 

    We can revert to a composition model later, but for the moment this will make our lives easier
    @cygnusv
    cygnusv committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    6f3d2d2 View commit details
    Browse the repository at this point in the history

  8. Further simplify FeeModel contracts since Coordinator now extends them

    @cygnusv
    cygnusv committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    dae568a View commit details
    Browse the repository at this point in the history

  9. Adapt tests to new FeeModel situation

    @cygnusv
    cygnusv committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    168c8ca View commit details
    Browse the repository at this point in the history

  10. Pass raw signature input when checking encryption authorization, inst… 

    …ead of hash
    @cygnusv
    cygnusv committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    3e52784 View commit details
    Browse the repository at this point in the history

  11. Optimize lookup mapping in GlobalAllowList 

    Closes nucypher#97
    @cygnusv
    cygnusv committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    ff0fee6 View commit details
    Browse the repository at this point in the history

  12. Further checks when setting Coordinator in AllowList contracts

    @cygnusv
    cygnusv committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    d05d202 View commit details
    Browse the repository at this point in the history

  13. Define TREASURY_ROLE to manage DKG fees

    @cygnusv
    cygnusv committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    7de9a24 View commit details
    Browse the repository at this point in the history

  14. Change fee refund approach to everything minus cost for a day

    @cygnusv
    cygnusv committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    76c1af5 View commit details
    Browse the repository at this point in the history

  15. Remove outdated TODOs

    @cygnusv
    cygnusv committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    e36477f View commit details
    Browse the repository at this point in the history

  16. Solhint changes

    @cygnusv
    cygnusv committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    2263b47 View commit details
    Browse the repository at this point in the history