[Do Not Merge] Brownie artifacts for SubscriptionManager deployment on Matic #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still, I experience issue nucypher#17 (TX was incorrectly reported to be dropped)
cygnusv
requested review from
vzotova,
derekpierre,
KPrasch,
manumonti and
theref
theref
approved these changes
Mar 31, 2022
| @@ -3,7 +3,12 @@ __pycache__ | |||
| .history | |||
| .hypothesis/ | |||
| .tox/ | |||
| build/ | |||
There was a problem hiding this comment.
This is pretty unusual, will each deployment need to be added to the .gitignore? I guess this links with #18
manumonti
approved these changes
Apr 1, 2022
manumonti
approved these changes
Apr 1, 2022
derekpierre
reviewed
Apr 1, 2022
Comment on lines
+7
to
+8
| !build/deployments/ | ||
| build/deployments/* |
There was a problem hiding this comment.
This is conflicted no?
Is it that you want to exclude build/deployments and then make specific exceptions for build/deployments/map.json , build/deployments/1, build/deployments/137. If so, then L7 (!build/deployments/) can probably go away.
There was a problem hiding this comment.
^ Ping @cygnusv . More broadly, PR needs a rebase.
KPrasch
approved these changes
Apr 20, 2023
KPrasch
changed the title
|
Obsoleted by #119 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still need to decide on #18, but for the moment this is the raw deployment information