Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI job for testing deployment functionality, and validate registries #317

Merged
merged 6 commits into from
Aug 23, 2024
Merged

CI job for testing deployment functionality, and validate registries #317

merged 6 commits into from
Aug 23, 2024

Conversation

derekpierre
Copy link
Member

@derekpierre derekpierre commented Aug 22, 2024 •
edited
Loading

Type of PR:

  • Bugfix
  • Feature
  • Documentation
  • Other

Required reviews:

  • 1
  • 2
  • 3

What this does:

High-level idea of the changes introduced in this PR.
List relevant API changes (if any), as well as related PRs and issues.

Based over #316 .

As part of the CI job test:

  • deployment of some contracts to local test blockchain works - includes proxy functionality, constants, function encoding, writing to a registry etc.
  • listing of contracts from contract registries (mainnet and testnets) works i.e. registries are valid.

Issues fixed/closed:

  • Fixes #...

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network.
E.g., if this PR address a nucypher/productdev issue, let reviewers know!

Notes for reviewers:

What should reviewers focus on?
Is there a particular commit/function/section of your PR that requires more attention from reviewers?

@derekpierre derekpierre changed the title [WIP] Ci job step for testing deployment functionality, and valid registries [WIP] Ci job for testing deployment functionality, and validate registries Aug 23, 2024
@derekpierre derekpierre self-assigned this Aug 23, 2024
@derekpierre derekpierre changed the title [WIP] Ci job for testing deployment functionality, and validate registries Ci job for testing deployment functionality, and validate registries Aug 23, 2024
@derekpierre derekpierre marked this pull request as ready for review August 23, 2024 00:59
manumonti
manumonti approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@manumonti manumonti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test! 🙌

@derekpierre derekpierre changed the title Ci job for testing deployment functionality, and validate registries CI job for testing deployment functionality, and validate registries Aug 23, 2024
cygnusv
cygnusv approved these changes Aug 23, 2024
View reviewed changes
deployment/constructor_params/ci/child.yml
constants:
ONE_HOUR_IN_SECONDS: 3600
FORTY_THOUSAND_TOKENS_IN_WEI_UNITS: 40000000000000000000000
TEN_MILLION_TOKENS_IN_WEI_UNITS: 10000000000000000000000000 # https://www.youtube.com/watch?v=EJR1H5tf5wE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see that Dr. Evil is making his way into our CI

@derekpierre derekpierre merged commit 346f364 into nucypher:main Aug 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cygnusv cygnusv cygnusv approved these changes

@vzotova vzotova vzotova approved these changes

@manumonti manumonti manumonti approved these changes

@KPrasch KPrasch Awaiting requested review from KPrasch

@theref theref Awaiting requested review from theref

Assignees

@derekpierre derekpierre

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@derekpierre @cygnusv @vzotova @manumonti