-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow nodes to specify the "[decryption] request encrypting key" for E2EE threshold decryption requests #80
Conversation
// nodes commit to their aggregation result | ||
bytes32 aggregatedTranscriptDigest = keccak256(aggregatedTranscript); | ||
participant.aggregated = true; | ||
participant.requestEncryptingKey = requestEncryptingKey; // TODO validation? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the top of my head: I don't know if we should validate this key (or how), but if we reuse requestEncryptingKey
as transcript verification, then that gives us some sort of reference point to the validity of this key. Related: #77
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had the same thought of just re-using the ferveo public blinding key as the request encrypting key in nucypher/nucypher#3081. It would be efficient.
However, @cygnusv had some thoughts about using a different cryptographic scheme than ferveo, perhaps one more browser-compatible. The request and response encrypting keys (see #nucypher/nucypher#3123) should probably use the same scheme so that is a consideration for the scheme we end up using. We just haven't nailed down which one to use as yet. Across the E2EE code, I've used Umbral for now as a placeholder to change later, but we should have a conversation soon about what scheme to use. If Ferveo then this PR can replace #77 with some tweaks, if not then it would be a separate feature.
50bad97
to
f14d09e
Compare
…hould be used when making threshold decryption requests to nodes.
Based over #81
Related to nucypher/nucypher#3081.
Corresponding
nucypher/nucypher
PR to account for extrapostAggregation
parameter, and extra member in Participant struct done in nucypher/nucypher#3123