Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support increased number of nodes in coordinator tests #90

Merged

Conversation

piotr-roslaniec
Copy link
Contributor

@piotr-roslaniec piotr-roslaniec commented Jun 26, 2023

@piotr-roslaniec piotr-roslaniec marked this pull request as ready for review June 28, 2023 11:59
@cygnusv cygnusv changed the base branch from main to development July 3, 2023 10:32
@cygnusv
Copy link
Member

cygnusv commented Jul 3, 2023

  • Fixes Providers not sorted thrown in test_coordinator.py due to case-insensitive sorting of providers

Good catch!

  • Increases the number of test accounts to 67 (64 nodes + 3 technical accounts)

Not sure if increasing the number of nodes in the test is really necessary in the long-term. In this current shape, it's just going to make the overall test time to be longer. Our protocol, from the point of view of node operations to the Coordinator, is constant-time (constant-gas, if we're nit-picky) except for:

  • Transcript size: This is what could really benefit from make it dependent on the cohort size, but we would need to have a clear formula for this (or at least, a good approximation)
  • the function getParticipantFromProvider(), which I'm planning to make constant-time in a forthcoming PR

So, I'd propose to keep the test node count low (anything between 4 and 8 is fine) and make the transcript size depend on the node count.

@piotr-roslaniec
Copy link
Contributor Author

I agree with your analysis. I reverted the number of accounts and added a dynamic transcript size. For now, it uses an approximated formula and in the future, we can replace the actual ferveo::Transcript creation if needed.

Copy link
Member

@manumonti manumonti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🙌

Maybe we should edit the description of this PR since AFAIK we are not increasing the number of test accounts to 67 with these changes.

  • Increases the number of test accounts to 67 (64 nodes + 3 technical accounts)

@piotr-roslaniec piotr-roslaniec merged commit 951187c into nucypher:development Jul 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants