Coordinator Alpha 12 #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optimize Ritual struct layout
Also replace contract owner for parameter administration role
Initiator is just the entity that calls initiateRitual(), needs to be authorized, and provides initial payment. Authority is who controls ritual lifecycle going forward.
Fee Models dictate what's the cost for rituals
Also, changes AccessControl base contract for the more specific AccessControlDefaultAdminRules
Also, change isInitiationRegulated to isInitiationPublic
Can't revoke INITIATOR_ROLE addresses since our AccessControl doesn't inherit from AccessControlEnumerable. It doesn't matter much anyway
We may want to parametrize tests based on this
Add also previous StakeInfo deployment on Mumbai
Either ritual is successful and fees can be used by the protocol, or ritual is failed and fees are refunded to initiator (consider partial refund)
…es long (as of nucypher-core v0.10.0).
KPrasch
changed the title
KPrasch
changed the title
General repo improvements
…or the moment We currently define it as the lowest value that produces a threshold set that's strictly greater than the 50% of the overall size. See nucypher/nucypher#3095
We can revert to a composition model later, but for the moment this will make our lives easier
Yet another batch of improvements for Coordinator
This was referenced Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.