Tracking changes for [email protected] update
#69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #69 +/- ##
==========================================
- Coverage 21.09% 21.07% -0.03%
==========================================
Files 17 17
Lines 3195 3194 -1
==========================================
- Hits 674 673 -1
Misses 2521 2521
|
This was referenced Jul 4, 2023
This was referenced Jul 7, 2023
piotr-roslaniec
requested review from
fjarri,
KPrasch,
theref,
derekpierre and
manumonti
manumonti
approved these changes
Jul 8, 2023
Merged
piotr-roslaniec
changed the title
[email protected] update[email protected] update
Given that nucypher-core is still has major version zero, a "minor" bump is still within the semver spec as far as I understand it: https://semver.org/#spec-item-4 |
KPrasch
approved these changes
Jul 11, 2023
|
@KPrasch You're right, I actually meant MINOR as in |
derekpierre
reviewed
Jul 11, 2023
| @@ -742,7 +733,7 @@ mod tests { | |||
| &ciphertext, | |||
| Some(&Conditions::new("abcd")), | |||
| Some(&Context::new("efgh")), | |||
| FerveoVariant::SIMPLE, | |||
| FerveoVariant::Simple, | |||
There was a problem hiding this comment.
Is there an equivalent test case for a request that uses Precomputed? You could do one within this same test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
Issues fixed/closed:
FerveoPublicKeyserialization ferveo#136FerveoVariantfrom bindings ferveo#137FerveoVariantin language bindings #68Why it's needed:
Notes for reviewers:
[email protected]update nucypher#3171