Address PR comments in #74 #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #77 +/- ##
==========================================
+ Coverage 23.38% 23.40% +0.01%
==========================================
Files 18 18
Lines 3540 3547 +7
==========================================
+ Hits 828 830 +2
- Misses 2712 2717 +5
|
piotr-roslaniec
requested review from
jMyles,
KPrasch,
cygnusv,
theref,
derekpierre and
manumonti
piotr-roslaniec
added
the
do not merge
7 tasks
|
rebased @ 43f943e (@piotr-roslaniec) |
fjarri
reviewed
Aug 28, 2023
| @@ -22,6 +21,8 @@ pub struct AuthenticatedData { | |||
| pub conditions: Option<Conditions>, | |||
| } | |||
|
|
|||
| impl Eq for AuthenticatedData {} | |||
There was a problem hiding this comment.
Does it work if you just add it to the list in #[derive]?
There was a problem hiding this comment.
Not quite. We'd also need to #[derive(Eq)] for DkgPublicKey in ferveo
manumonti
approved these changes
Aug 28, 2023
derekpierre
reviewed
Aug 29, 2023
| @@ -1101,7 +1101,7 @@ impl ReencryptionResponse { | |||
|
|
|||
| Ok(Self(nucypher_core::ReencryptionResponse::new( | |||
| signer.as_ref(), | |||
| backend_capsules.iter().zip(backend_vcfrags.into_iter()), | |||
| backend_capsules.iter().zip(backend_vcfrags), | |||
There was a problem hiding this comment.
@piotr-roslaniec Let's be careful changing old PRE code unless necessary.
Is it that into_iter() no longer works, or is zip(...) just best practice?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
unwrap(), and handles errors gracefully insteadPartialEqimpl. with aderivemacrostable(1.7.2)Issues fixed/closed:
Why it's needed:
Notes for reviewers: