Conditions should not be optional for CBD types #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ata and AccessControlPolicy.
derekpierre
requested review from
fjarri,
jMyles,
KPrasch,
cygnusv,
theref,
manumonti and
piotr-roslaniec
derekpierre
changed the title
derekpierre
force-pushed
the
not-optional
branch
from
e907c0b
to
d998516
Compare
piotr-roslaniec
approved these changes
Aug 30, 2023
manumonti
approved these changes
Aug 31, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ata and AccessControlPolicy.
Type of PR:
Required reviews:
What this does:
Issues fixed/closed:
Related to #76 .
Why it's needed:
Conditions should not be optional for CBD - it's kind of the whole point.
Notes for reviewers:
Already ran parts of the test suite locally with
nucypherto test python bindings. There are no downstream changes necessary fornucypherother than an updatednucypher-coredependency, because conditions were not optional for CBD functionality innucypheranyway.