Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): use binary wasm-pack distribution #81

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

piotr-roslaniec
Copy link
Contributor

Type of PR:

  • Other

Required reviews:

  • 1

What this does:

  • Installs wasm-pack from a precompiled binary
  • Fixes a listing issue on Rust stable
  • Copies changes from Fix CI build ferveo#159

Why it's needed:

  • Some child dependencies in wasm-pack an wasm-opt get updated from time to time and that causes MSRV float
  • With these changes, we should be able to avoid that in the future, and hence avoid CI breaking from time to time

@codecov-commenter
Copy link

Codecov Report

Merging #81 (1f2e60f) into main (a43b78d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #81   +/-   ##
=======================================
  Coverage   23.40%   23.40%           
=======================================
  Files          18       18           
  Lines        3547     3547           
=======================================
  Hits          830      830           
  Misses       2717     2717           

@piotr-roslaniec piotr-roslaniec marked this pull request as ready for review September 1, 2023 20:01
Copy link
Member

@manumonti manumonti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@piotr-roslaniec piotr-roslaniec merged commit 7f8df14 into nucypher:main Sep 4, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants