Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Porter Updates associated with nucypher 7.3.0 #69

Merged
merged 17 commits into from
May 8, 2024
Merged

Porter Updates associated with nucypher 7.3.0 #69

merged 17 commits into from
May 8, 2024

Conversation

derekpierre
Copy link
Member

@derekpierre derekpierre commented May 2, 2024 •
edited
Loading

@derekpierre
Relock using updated nucypher dependency that accomodates migration…
a17c6a6 
… from Mumbai to Amoy.
@derekpierre
Fix testing based on latest changes in nucypher dependency.
01378c2
@derekpierre
Use Porter version as info version value.
2639bed
@derekpierre
Use python 3.9 for relocks, and limit version of numpy; 2.0 rc has so…
252b2e4 
…me issues.
@derekpierre
Relock dependencies based on nucypher v7.3.x now that relevant change…
e6f4f74 
…s have been merged.
@derekpierre
Merge pull request #68 from derekpierre/leonard-n-amoy
5d6a416 
Add support for Polygon Amoy and `nucypher` v7.3.x
@derekpierre
Relock dependencies to latest nucypher version on branch v7.3.x.
642afa0
@derekpierre
Add NonNegativeInteger field and associated tests.
3c203c8
@derekpierre
Add the ability to specify duration as an optional parameter for the …
0f91606 
…/get_ursulas endpoint.
@derekpierre
Add tests for duration parameter for /get_ursulas endpoint.
eb53405
@derekpierre
Add duration parameter to bucket sampling endpoint.
9565f4b
@derekpierre
Update bucket sampling tests and get ursulas tests to skip specific n…
07b795d 
…ode if duration > 0.
@derekpierre
Update tests based on updated fixtures from nucypher; reserved acco…
617a49b 
…unts are managed by a separate test account manager instead of testerchain.
@derekpierre
Set separate max timeout for bucket sampling endpoint which can take …
4e2cb87 
…longer because it wants the ursula ping check to complete before looking for other ursulas, so that the list of staking providers returned is mostly deterministic for the same random seed value.

Reduce stagger timout since ping already has a connection timeout of 3.05s from `nucypher`.
@derekpierre
Update version of codecov action for CI.
c1b7e65
@derekpierre
Merge pull request #67 from derekpierre/duration-sampling
5a964fd 
Duration Sampling
@derekpierre derekpierre changed the title v3.6.0 Porter Updates associated with nucypher 7.3.0 May 2, 2024
@derekpierre derekpierre changed the title Porter Updates associated with nucypher 7.3.0 Porter Updates associated with nucypher 7.3.0 May 2, 2024
@derekpierre derekpierre self-assigned this May 7, 2024
@derekpierre derekpierre marked this pull request as ready for review May 7, 2024 14:43
@derekpierre
Copy link
Member Author

derekpierre commented May 7, 2024 •
edited
Loading

Once merged - we need to do a release for Porter.

@KPrasch, @manumonti could use some help via a joint session: bumpversion, release etc.

piotr-roslaniec
piotr-roslaniec approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@piotr-roslaniec piotr-roslaniec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I don't see any downstream changes for taco-web, please correct me if I'm wrong.

@derekpierre
Copy link
Member Author

LGTM

I don't see any downstream changes for taco-web, please correct me if I'm wrong.

Good question - the sampling endpoints /get_ursulas and /bucket_sampling now take an extra optional parameter for duration (defaults to 0 if not provided); related to nucypher/nucypher-contracts#240.

AFAIK taco-web doesn't do any sampling (?), so taco-web is probably fine for now, unless I'm mistaken, but perhaps in the future if it adds any sampling functionality.

@piotr-roslaniec
Copy link
Contributor

taco-web doesn't do any sampling at the moment. Perhaps in the future, we will make use of these endpoints once we develop a ritual initiation user flow.

manumonti
manumonti approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@manumonti manumonti left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

Please, lmk if I can help with the update @derekpierre @KPrasch

@derekpierre derekpierre merged commit 175bb7a into main May 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manumonti manumonti manumonti approved these changes

@piotr-roslaniec piotr-roslaniec piotr-roslaniec approved these changes

@KPrasch KPrasch Awaiting requested review from KPrasch

@cygnusv cygnusv Awaiting requested review from cygnusv

@theref theref Awaiting requested review from theref

@vzotova vzotova Awaiting requested review from vzotova

Assignees

@derekpierre derekpierre

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@derekpierre @piotr-roslaniec @manumonti