Replace deprecated actions-rs/* GH Actions
#133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotr-roslaniec
force-pushed
the
replace-actions-rs
branch
from
10974b5
to
a1feeaf
Compare
piotr-roslaniec
force-pushed
the
replace-actions-rs
branch
from
67a9581
to
f26eb43
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #133 +/- ##
=======================================
Coverage 58.08% 58.08%
=======================================
Files 17 17
Lines 3123 3123
=======================================
Hits 1814 1814
Misses 1309 1309 ☔ View full report in Codecov by Sentry. |
piotr-roslaniec
changed the title
actions-rs/* GH Actions
piotr-roslaniec
requested review from
KPrasch,
cygnusv,
theref,
derekpierre and
manumonti
theref
approved these changes
Jan 22, 2024
manumonti
approved these changes
Jan 22, 2024
| @@ -59,7 +59,7 @@ fn hash(data: impl AsRef<[u8]>) -> i64 { | |||
| // we just need something fast that minimizes conflicts. | |||
| let digest = Sha256::new().chain(data).finalize(); | |||
| let (chunk, _): (GenericArray<u8, U8>, _) = digest.split(); | |||
| let arr: [u8; 8] = chunk.try_into().unwrap(); | |||
| let arr: [u8; 8] = chunk.into(); | |||
There was a problem hiding this comment.
Just out of curiosity: is this change related to these GH Actions in some way?
There was a problem hiding this comment.
I think it's an accidental change. It's possible that clippy was updated between the previous CI run and now, and it resulted in a broken linter rule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
actions-rs/*GH Actions ferveo#153actions-rs/*GH Actions nucypher-core#90