Update to [email protected]

[piotr-roslaniec]

• Update nucypher-core after 0.11.0 version is released

Type of PR:

• Other

Required reviews:

• 1

What this does:

• Updates nucypher-ts for compatibility with a new nucypher-core version

Issues fixed/closed:

• Closes Use FerveoVariant exposed by nucypher-core #236

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network.
E.g., if this PR address a nucypher/productdev issue, let reviewers know!

Notes for reviewers:

• No breaking changes

[piotr-roslaniec]

To be updated after [email protected] release

[manumonti]

LGTM! 👍

[manumonti]

Just out of curiosity: why has this been changed from switch conditionals to If/ else if?

[piotr-roslaniec]

Implementing comparison for WASM objects is tricky (==, ===). If we were to simply run a1 === a2, it's going to fail even though a1 and a2 are identical. This is because JS will attempt to compare WASM objects which are just pointers to some memory on the heap (and not the values of the objects). This is why we expose equals method - to compare the underlying values and not the pointers.

So previously we sort of got away without doing all of that because FerveoVariant was just a number. And you can compare primitive types just fine, so === and == work. switch statement is relying on equality, so we could use it with number. Again, all was good.

Now that the FerveoVariant is a WASM object instead of a number primitive type we can't use switch anymore, we have to manually compare objects using equals.

Perhaps there is a better way to do that, like somehow implementing a native === overloading in wasm-bindgen, but I didn't figure out it yet.

[manumonti]

Ok, got it. Thanks for the elaborate explanation, Piotr 🙌

[codecov-commenter]

Codecov Report

Merging #250 (e5f6117) into alpha (49fa8ab) will increase coverage by 0.09%.
The diff coverage is 53.84%.

@@            Coverage Diff             @@
##            alpha     #250      +/-   ##
==========================================
+ Coverage   80.56%   80.66%   +0.09%     
==========================================
  Files          37       37              
  Lines        1055     1050       -5     
  Branches      144      141       -3     
==========================================
- Hits          850      847       -3     
+ Misses        196      194       -2     
  Partials        9        9              

Files Changed	Coverage Δ
src/characters/cbd-recipient.ts	90.90% <ø> (ø)
src/dkg.ts	48.00% <50.00%> (-0.75%)	⬇️
src/index.ts	100.00% <100.00%> (ø)