Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release [email protected] #463

Merged
merged 7 commits into from
Jan 15, 2024

Conversation

piotr-roslaniec
Copy link
Contributor

Type of PR:

  • Other

Required reviews:

  • 1

Why it's needed:

  • One of the underlying dependencies, @nucypher/nucypher-contracts was updated
  • Necessary to keep taco-web working for tapir users

Copy link

netlify bot commented Jan 11, 2024

Deploy Preview for taco-demo ready!

Name Link
🔨 Latest commit 3c675f3
🔍 Latest deploy log https://app.netlify.com/sites/taco-demo/deploys/65a15b08a74378000960c8df
😎 Deploy Preview https://deploy-preview-463--taco-demo.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 11, 2024

Deploy Preview for taco-nft-demo ready!

Name Link
🔨 Latest commit 3c675f3
🔍 Latest deploy log https://app.netlify.com/sites/taco-nft-demo/deploys/65a15b089ed3aa0008c19b19
😎 Deploy Preview https://deploy-preview-463--taco-nft-demo.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (850d018) 23.97% compared to head (3c675f3) 23.97%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #463   +/-   ##
=======================================
  Coverage   23.97%   23.97%           
=======================================
  Files          62       62           
  Lines        9792     9792           
  Branches      260      260           
=======================================
  Hits         2348     2348           
  Misses       7385     7385           
  Partials       59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@piotr-roslaniec piotr-roslaniec changed the title chore(release): release @nucypher/shared:0.2.0 Release [email protected] Jan 11, 2024
Copy link
Member

@manumonti manumonti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@@ -82,7 +82,7 @@
"node-forge@<1.3.0": ">=1.3.0",
"glob-parent@<5.1.2": ">=5.1.2",
"nth-check@<2.0.1": ">=2.0.1",
"@nucypher/nucypher-core": "0.13.0-alpha.1"
"@nucypher/nucypher-core": "^0.14.1"
Copy link
Member

@derekpierre derekpierre Jan 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Judging by nucypher/nucypher-core#89 there are no concerns about 0.14.1 not being compatible with nodes running 0.13.0, correct? The breaking changes were limited to the wasm bindings, which the nodes don't care about.

Copy link
Contributor Author

@piotr-roslaniec piotr-roslaniec Jan 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, these changes are strictly for nucypher-core-wasm and there is no impact on Python users.

@@ -1,6 +1,6 @@
{
"name": "@nucypher/taco",
"version": "0.1.0",
"version": "0.2.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 0.2.2 and not 0.2.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I messed up and published a bad build. I yanked previous versions, but npmjs.com doesn't allow republishing so I had to bump the version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok 👍

Should the demos (taco-demo, taco-nft-demo) update their dependency to 0.2.2?

@piotr-roslaniec piotr-roslaniec merged commit 4e86f65 into nucypher:main Jan 15, 2024
7 checks passed
@piotr-roslaniec piotr-roslaniec deleted the release-taco-0.2.0 branch January 15, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants