Validate user-provided AuthSignature
#537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotr-roslaniec
force-pushed
the
auth-sig-validation
branch
3 times, most recently
from
bbfae8c
to
5dd8396
Compare
piotr-roslaniec
force-pushed
the
auth-sig-validation
branch
2 times, most recently
from
776a065
to
e8649d8
Compare
piotr-roslaniec
requested review from
KPrasch,
cygnusv,
theref,
derekpierre and
manumonti
piotr-roslaniec
force-pushed
the
auth-sig-validation
branch
from
e8649d8
to
85cd025
Compare
piotr-roslaniec
force-pushed
the
epic-auth
branch
from
4eea8e7
to
5a4d072
Compare
piotr-roslaniec
force-pushed
the
auth-sig-validation
branch
from
85cd025
to
3fdf1d9
Compare
piotr-roslaniec
force-pushed
the
auth-sig-validation
branch
from
3fdf1d9
to
be42ddc
Compare
theref
reviewed
Jul 3, 2024
| @@ -36,11 +38,24 @@ export class LocalStorage { | |||
| : new BrowserStorage(); | |||
| } | |||
|
|
|||
| getItem(key: string): string | null { | |||
| return this.storage.getItem(key); | |||
| public getAuthSignature(key: string): AuthSignature | null { | |||
cygnusv
reviewed
Jul 3, 2024
packages/shared/src/schemas.ts
Outdated
| import { z } from 'zod'; | ||
|
|
||
| export const ETH_ADDRESS_REGEXP = new RegExp('^0x[a-fA-F0-9]{40}$'); | ||
| export const EthAddressSchema = z.string().regex(ETH_ADDRESS_REGEXP); |
There was a problem hiding this comment.
Should we go a step further and validate the address with ethers and a zod .refine?
packages/taco-auth/src/storage.ts
Outdated
| } | ||
|
|
||
| setItem(key: string, value: string): void { | ||
| this.storage.setItem(key, value); | ||
| public static toJson(signature: AuthSignature): string { |
There was a problem hiding this comment.
Not a blocker but it's a bit weird that json<=>authsignature conversion methods are part of the storage interface
manumonti
approved these changes
Jul 3, 2024
packages/test-utils/src/utils.ts
Outdated
| @@ -53,8 +53,8 @@ export const fromBytes = (bytes: Uint8Array): string => | |||
|
|
|||
| export const fakePorterUri = 'https://_this_should_crash.com/'; | |||
|
|
|||
| const makeFakeProvider = (timestamp: number, blockNumber: number) => { | |||
| const block = { timestamp }; | |||
| const makeFakeProvider = (timestamp: number, blockNumber: number, blockHash: string) => { | |||
There was a problem hiding this comment.
Not relevant for this PR, but shouldn't the code formatter split this line in several ones?
Suggested change
| const makeFakeProvider = (timestamp: number, blockNumber: number, blockHash: string) => { | |
| const makeFakeProvider = ( | |
| timestamp: number, | |
| blockNumber: number, | |
| blockHash: string, | |
| ) => { |
derekpierre
reviewed
Jul 3, 2024
|
|
||
| export type EIP4361TypedData = string; | ||
|
|
||
| export const EIP4361TypedDataSchema = z.string(); |
There was a problem hiding this comment.
Should we use zod refine here as well? You can try calling the SiweMessage constructor as part of the refine function to ensure that the string can be parsed properly.
There was a problem hiding this comment.
Addressed here: f9e2030 (#527)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
AuthSignaturevalidation withzodtaco-authto prevent circular-dependency issues that breakzodIssues fixed/closed:
Why it's needed:
Notes for reviewers: