GitHub Porter URIs

[vzotova]

Type of PR:

• Bugfix
• Feature
• Documentation
• Other

Required reviews:

• 1
• 2
• 3

What this does:

High-level idea of the changes introduced in this PR.
List relevant API changes (if any), as well as related PRs and issues.

Issues fixed/closed:
Fixes #320

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network.
E.g., if this PR address a nucypher/productdev issue, let reviewers know!

Notes for reviewers:
Based on #553

[vzotova]

@piotr-roslaniec @cygnusv @theref To finish that PR I'd like to ask you where JSON should be stored? It can be empty for the beginning

[piotr-roslaniec]

IMHO https://github.com/nucypher/nucypher-porter repo is fine for this purpose

[netlify]

✅ Deploy Preview for taco-nft-demo canceled.

Name	Link
🔨 Latest commit	7027418
🔍 Latest deploy log	https://app.netlify.com/sites/taco-nft-demo/deploys/66be5b7d7a6e1400083994ec

[netlify]

✅ Deploy Preview for taco-demo canceled.

Name	Link
🔨 Latest commit	7027418
🔍 Latest deploy log	https://app.netlify.com/sites/taco-demo/deploys/66be5b7d9eef930008be60a3

[piotr-roslaniec]

Why the ! assertion?

[vzotova]

to mark it's 100% assigned, vs code was showing error without it

[piotr-roslaniec]

It's a minor smell so I guess we let it slide. But at any rate, let statements where we assign value later should not be required to ! if the branching is done properly

[piotr-roslaniec]

@vzotova Before we merge this, it may be helpful to run the Node.js example using these new Porter URLs

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 80.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 79.56%. Comparing base (e8f9098) to head (7027418).
Report is 144 commits behind head on main.

Files	Patch %	Lines
packages/shared/src/porter.ts	81.08%	5 Missing and 2 partials ⚠️
packages/taco/src/taco.ts	66.66%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main     #555       +/-   ##
===========================================
+ Coverage   23.12%   79.56%   +56.43%     
===========================================
  Files          62       65        +3     
  Lines       10175     6806     -3369     
  Branches      260      299       +39     
===========================================
+ Hits         2353     5415     +3062     
+ Misses       7763     1349     -6414     
+ Partials       59       42       -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[derekpierre]

🎸