Contributor docs #562
Open
Contributor docs #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Manuel Montenegro <[email protected]>
✅ Deploy Preview for taco-nft-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for taco-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
derekpierre
reviewed
Aug 1, 2024
|
|
||
| 3. User Context Management: | ||
|
|
||
| They help manage user context, specifically the `:userAddress` parameter. This includes handling authentication tokens and ensuring that users are authenticated only once for multiple actions. |
There was a problem hiding this comment.
There is also the :userAddressExternalEIP4361 context variable.
It also uses an auth provider for generating the AuthSignature - https://github.com/nucypher/taco-web/blob/main/packages/taco-auth/src/providers/external-eip4361.ts#L6.
Side note: my goal is to update the API via #560 in the next sprint.
| [The below test](https://github.com/nucypher/taco-web/blob/b689493a37bec0b168f80f43347818095c3dd5ce/packages/taco/test/conditions/context.test.ts#L382C1-L429C6) demonstrates how a SIWE message can be reused for TACo authentication. | ||
| This ensures that users don't have to sign multiple messages when logging into apps and decrypting TACo messages. | ||
|
|
||
| ```typescript |
There was a problem hiding this comment.
Is this test in a test file somewhere already? Can we link to to test files/line numbers instead? That would ensure that the test always remains fresh. Some for other spots above.
| EIP-712 has previously been supported but is now deprecated. | ||
|
|
||
| [The below test](https://github.com/nucypher/taco-web/blob/b689493a37bec0b168f80f43347818095c3dd5ce/packages/taco/test/conditions/context.test.ts#L382C1-L429C6) demonstrates how a SIWE message can be reused for TACo authentication. | ||
| This ensures that users don't have to sign multiple messages when logging into apps and decrypting TACo messages. |
There was a problem hiding this comment.
Suggested change
| This ensures that users don't have to sign multiple messages when logging into apps and decrypting TACo messages. | |
| This ensures that users don't have to sign multiple messages when already logged into apps via SIWE and need to decrypt messages via TACo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same PR as #551. The previous PR was closed due to the destination branch being deleted.
Type of PR:
Required reviews:
Fixes https://github.com/nucypher/sprints/issues/27