Support Eslint 7 & add rules #15
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,23 +15,40 @@ module.exports = { | |
| 'flowtype/delimiter-dangle': ['error', 'always-multiline', 'always-multiline', 'always-multiline'], | ||
| 'flowtype/generic-spacing': ['error', 'never'], | ||
| 'flowtype/newline-after-flow-annotation': ['error', 'always'], | ||
| 'flowtype/no-mixed': 'off', | ||
| 'flowtype/no-dupe-keys': 'error', | ||
| // TODO: enable? | ||
| 'flowtype/no-existential-type': 'off', | ||
|
There was a problem hiding this comment. I think can be enabled since |
||
| 'flowtype/no-flow-fix-me-comments': 'off', | ||
| 'flowtype/no-mixed': 'off', | ||
| // TODO: enable? | ||
| 'flowtype/no-mutable-array': 'off', | ||
|
There was a problem hiding this comment. I'm not sure if it forces us to only use https://github.com/gajus/eslint-plugin-flowtype/blob/master/.README/rules/no-mutable-array.md There was a problem hiding this comment. We have this
And also we will still be able to do perf optimisations using |
||
| 'flowtype/no-primitive-constructor-types': 'error', | ||
| 'flowtype/no-types-missing-file-annotation': 'error', | ||
| 'flowtype/no-unused-expressions': 'error', | ||
| // TODO: disable any? | ||
|
There was a problem hiding this comment.
|
||
| 'flowtype/no-weak-types': ['error', { any: false }], | ||
| 'flowtype/object-type-delimiter': ['error', 'comma'], | ||
| 'flowtype/require-compound-type-alias': ['error', 'always'], | ||
| 'flowtype/require-exact-type': 'off', | ||
| 'flowtype/require-indexer-name': 'off', | ||
| 'flowtype/require-inexact-type': 'off', | ||
| 'flowtype/require-parameter-type': 'off', | ||
| 'flowtype/require-readonly-react-props': 'error', | ||
| 'flowtype/require-return-type': 'off', | ||
| 'flowtype/require-types-at-top': 'error', | ||
|
There was a problem hiding this comment. This might lead to quite a number of changes, need to test it out. Some of our files have this kind of pattern, which we could either move to different files else the types would be difficult to see. https://github.com/gajus/eslint-plugin-flowtype/blob/master/.README/rules/require-types-at-top.md There was a problem hiding this comment. Yeah, would lead to lot of changes but this has autofix I think There was a problem hiding this comment. Yeah, I think so too. But some files might need to reorganise, should be a few I guess. |
||
| 'flowtype/require-valid-file-annotation': 'off', | ||
| 'flowtype/require-variable-type': 'off', | ||
| 'flowtype/semi': ['error', 'always'], | ||
| 'flowtype/sort-keys': ['error', 'asc', { caseSensitive: false, natural: true }], | ||
| 'flowtype/space-after-type-colon': ['error', 'always'], | ||
| 'flowtype/space-before-generic-bracket': ['error', 'never'], | ||
| 'flowtype/space-before-type-colon': ['error', 'never'], | ||
| // TODO: enable? | ||
| 'flowtype/spread-exact-type': 'off', | ||
|
There was a problem hiding this comment. There was a problem hiding this comment. I think it's because spreading non-exact type is not safe and not properly supported by flow There was a problem hiding this comment. Might be possible to enable 🤔 |
||
| 'flowtype/type-id-match': 'off', | ||
| // Use identifier as declaration imports are not well supported by vscode | ||
| 'flowtype/type-import-style': ['error', 'identifier'], | ||
|
There was a problem hiding this comment. Prefer this to be off. As at times, there is not a need to have https://github.com/gajus/eslint-plugin-flowtype/blob/master/.README/rules/type-import-style.md There was a problem hiding this comment. What about forcing There was a problem hiding this comment. Sure, we can force |
||
| 'flowtype/union-intersection-spacing': ['error', 'always'], | ||
| 'flowtype/use-flow-type': 'warn', | ||
| }, | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -53,6 +53,13 @@ module.exports = { | |
| // https://github.com/yannickcr/eslint-plugin-react/blob/843d71a432baf0f01f598d7cf1eea75ad6896e4b/docs/rules/forbid-dom-props.md | ||
| 'react/forbid-dom-props': ['off', { forbid: [] }], | ||
|
|
||
| // Enforce a specific function type for function components. | ||
| // https://github.com/yannickcr/eslint-plugin-react/blob/v7.20.0/docs/rules/function-component-definition.md | ||
| 'react/function-component-definition': ['error', { | ||
| namedComponents: 'function-declaration', | ||
| unnamedComponents: 'function-declaration', | ||
| }], | ||
|
There was a problem hiding this comment. I'm not sure about this. I prefer to write this way inside a function component, and this would probably prevent it 🤔 Also, There was a problem hiding this comment. This was mainly related to https://twitter.com/dan_abramov/status/1255229440860262400?s=09 There was a problem hiding this comment. Hmmms, true 🤔 But means inside class, we would also have to not use arrows then. We can try it out and see how many changes etc. There was a problem hiding this comment. No it's just on functions, class arrow functions will be good |
||
|
|
||
| // Enforce boolean attributes notation in JSX | ||
| // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-boolean-value.md | ||
| 'react/jsx-boolean-value': ['error', 'never', { always: [] }], | ||
|
|
@@ -82,7 +89,7 @@ module.exports = { | |
|
|
||
| // Validate JSX has key prop when in array or iterator | ||
| // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-key.md | ||
| 'react/jsx-key': ['error', { checkFragmentShorthand: true }], | ||
|
|
||
| // Limit maximum of props on a single line in JSX | ||
| // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-max-props-per-line.md | ||
|
|
@@ -177,7 +184,7 @@ module.exports = { | |
|
|
||
| // Prevent direct mutation of this.state | ||
| // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-direct-mutation-state.md | ||
| 'react/no-direct-mutation-state': 'error', | ||
|
|
||
| // Prevent usage of isMounted | ||
| // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-is-mounted.md | ||
|
|
@@ -476,12 +483,10 @@ module.exports = { | |
|
|
||
| // Enforce state initialization style | ||
| // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/state-in-constructor.md | ||
| 'react/state-in-constructor': ['error', 'never'], | ||
|
|
||
| // Enforces where React component static properties should be positioned | ||
| // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/static-property-placement.md | ||
| 'react/static-property-placement': ['error', 'static public field'], | ||
|
|
||
| // Disallow JSX props spreading | ||
|
|
@@ -494,7 +499,7 @@ module.exports = { | |
|
|
||
| // Enforce that props are read-only | ||
| // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/prefer-read-only-props.md | ||
| 'react/prefer-read-only-props': 'error', | ||
|
There was a problem hiding this comment. This might lead to a lot of changes but I think is most likely simple fixes. Not sure if it would be too verbose though. 🤔 There was a problem hiding this comment. I think I'll enable them one-by-one to have separated commits |
||
| }, | ||
|
|
||
| settings: { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing breaking changes
eslintto^7.10.0.