Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Media Session API Support to Nuclear (Menu Bar Issues #1647) #1727

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gr33nMari0
Copy link

@gr33nMari0 gr33nMari0 commented Oct 24, 2024

Working on the following Issue: Menu Bar Issues #1647

This begins the draft pull request for my implementation of Media Session support for Nuclear, to update the way Nuclear passes music metadata to the host OS for native control over music in panels such as the macOS Menu Bar "Now Playing" widget.

Current status - Music metadata has been added to the mediaSession Object in the navigator of the page. Fields such as Song Title and Artist have been implemented, and can be viewed already, and listeners for play/pause using IPC calls. Artwork URL is being passed but there is a bug preventing macOS from rendering this image as the album artwork, so this will be fixed in time. Testing for all the above will be added following a correct implementation - this is because my approach is quite volatile at the moment due to the large number of places that might be the most appropriate place to have the mediaSession initialisation calls.

Issues identified with my current implementation:

  • Thumnail rendering not working
  • Play/Pause IPC events not logged immediately after interacting with the macOS Widget, lack of sync between Play/Pause button on Nuclear and the macOS widget
  • Keyboard media keys have weird behaviour between macOS system-wide and when Nuclear is focused.
  • There isn't currently a way to retrieve current track progress, for live-updates of the playback bar in the macOS Menu Bar. This will need to be looked into.
  • Testing coverage for the helper methods added in the currently committed code is non-existent, and style/documentation will need to be added.

@gr33nMari0 gr33nMari0 changed the title Adding Media Session API Support to Nuclear Adding Media Session API Support to Nuclear (Menu Bar Issues #1647) Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant