Adding Media Session API Support to Nuclear (Menu Bar Issues #1647) #1727
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on the following Issue: Menu Bar Issues #1647
This begins the draft pull request for my implementation of Media Session support for Nuclear, to update the way Nuclear passes music metadata to the host OS for native control over music in panels such as the macOS Menu Bar "Now Playing" widget.
Current status - Music metadata has been added to the mediaSession Object in the navigator of the page. Fields such as Song Title and Artist have been implemented, and can be viewed already, and listeners for play/pause using IPC calls. Artwork URL is being passed but there is a bug preventing macOS from rendering this image as the album artwork, so this will be fixed in time. Testing for all the above will be added following a correct implementation - this is because my approach is quite volatile at the moment due to the large number of places that might be the most appropriate place to have the mediaSession initialisation calls.
Issues identified with my current implementation: