Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: First iteration of Conversations UI; wire up new messages API. #394

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

mathewjordan
Copy link
Member

@mathewjordan mathewjordan commented Dec 16, 2024

What does this do?

This iteration updates our handling of messages from the chat endpoint web socket. Some notes:

  • Types for streaming messages are redefined!
  • On components/Chat/Response/Response.tsx we are handling for token, answer, tool_start, search_result, and final_message. aggregation_result Is not yet doing anything, nor are we doing anything with the intermittent start and stop messages.
  • The interstitials rendering for the tool_start all utilize the same icon, but this could be extended to other SVGs as we refine this further.
  • IMPT this does not yet handle a continued conversation
  • We are now storing the completed rendered response in state once the final_message comes through.
  • Some tests are ignored as we iterate.

How should we review?

  1. Go to https://preview-5322-conversations-ui.dc.rdc-staging.library.northwestern.edu/search, OR spin up dev locally and set your environment:
NEXT_PUBLIC_DCAPI_ENDPOINT=https://dcapi-prototype.rdc-staging.library.northwestern.edu/api/v2
  1. Do a few searches.
  2. Conversations should roll in.
  3. New searches should reset response view as expected.

@mathewjordan mathewjordan marked this pull request as draft December 16, 2024 22:21
@mathewjordan mathewjordan changed the title First iteration of Conversations UI; wire up new messages API. WIP: First iteration of Conversations UI; wire up new messages API. Dec 16, 2024
@mathewjordan mathewjordan force-pushed the preview/5322-conversations-ui branch 2 times, most recently from f4760f7 to 1e5e1f2 Compare December 18, 2024 18:49
@mathewjordan mathewjordan self-assigned this Dec 18, 2024
@mathewjordan mathewjordan requested a review from bmquinn December 18, 2024 19:09
@mathewjordan mathewjordan force-pushed the preview/5322-conversations-ui branch from 1e5e1f2 to b9451d3 Compare December 18, 2024 19:11
@mathewjordan mathewjordan marked this pull request as ready for review December 18, 2024 19:12
@mathewjordan mathewjordan requested a review from mbklein December 18, 2024 19:12
Copy link
Contributor

@mbklein mbklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic.

@mathewjordan mathewjordan force-pushed the preview/5322-conversations-ui branch from b9451d3 to c346c06 Compare December 18, 2024 20:13
@mathewjordan mathewjordan merged commit 5171309 into preview/conversations Dec 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants