Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retries to HTTP timeouts in Meadow.Search.HTTP and Meadow.Utils.AWS #4386

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

mbklein
Copy link
Contributor

@mbklein mbklein commented Feb 4, 2025

Summary

Add HTTP retries to AWS and OpenSearch clients

Specific Changes in this PR

  • Add retry functionality to Meadow.Search.HTTP.request/5
  • Add retry functionality to Meadow.Utils.AWS.request/2

Version bump required by the PR

See Semantic Versioning 2.0.0 for help discerning which is required.

  • Patch
  • Minor
  • Major

Steps to Test

This is a tricky one to test. A largish ingest sheet should go through successfully (all the way through to indexing), but there's no way to guarantee a timeout will happen so there's no way to guarantee that you'll see it recover from one. Best choice is to see that it doesn't break anything, and watch for further errors in production.

🚀 Deployment Notes

Note - if you check any of these boxes go to the (always open) main <- staging PR and add detailed notes and instructions to help out others who may end up deploying your changes to production

  • Backward compatible API changes
    • Database Schema changes
    • GraphQL API
    • Elasticsearch API
    • Ingest Sheet
    • CSV metadata export/update API
    • Shared Links export API
  • Backwards-incompatible API changes
    • Database Schema changes
    • GraphQL API
    • Elasticsearch API
    • Ingest Sheet
    • CSV metadata export/update API
    • Shared Links export API
  • Requires data migration
  • Requires database triggers disabled during deployment/migration
  • Requires reindex
  • Terraform changes
    • Adds/requires new or changed Terraform variables
  • Pipeline configuration changes (requires mix meadow.pipeline.setup run)
  • Requires new variable added to miscellany
  • Specific deployment synchronization instructions with other apps/API's
  • Other specific instructions/tasks

Tested/Verified

  • End users/stakeholders

@mbklein mbklein merged commit eebdcc3 into deploy/staging Feb 4, 2025
3 checks passed
@mbklein mbklein deleted the 5333-timeouts branch February 4, 2025 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants