Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support min: / max: options for y-axis range #67

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rmosolgo
Copy link

@rmosolgo rmosolgo commented Mar 4, 2022

I noticed that charts always had 0 as the minimum y-axis value, but I wanted some charts with different ranges. I found a way to add it, what do you think of this change?

TODO:

  • this doesn't quite work, the chart is graphed wrong -- as if it's assuming somewhere that the bottom is zero.
    • Ah, found it! It seems like the code supported either a negative min or zero, but it wouldn't use a given min if it was greater than zero. I updated it to use 0 only if no min is given.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant