Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪲 fix vacuum conversion #93

Merged
merged 2 commits into from
Jul 8, 2024
Merged

🪲 fix vacuum conversion #93

merged 2 commits into from
Jul 8, 2024

Conversation

JavanW-W
Copy link
Contributor

@JavanW-W JavanW-W commented Jul 8, 2024

Setpoint is given in mmHg and should be converted to mbar

@JavanW-W JavanW-W requested a review from juli4nb4dillo July 8, 2024 16:57
@juli4nb4dillo
Copy link
Member

I undid this because of #69 and I have evidence that it the setpoint was on a different unit than the reading.
It's probably something to to with the instrument setting itself (I have no idea).
But let's go ahead, I don't like units being different in setting than reading.

@juli4nb4dillo
Copy link
Member

Ah, wait, if you're fixing this, you gotta bump the version.

@JavanW-W JavanW-W merged commit 0cbe3d1 into master Jul 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants