Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix KeyError when reading > 124 modbus tags #72

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Fix KeyError when reading > 124 modbus tags #72

merged 2 commits into from
Jun 28, 2023

Conversation

alexrudd2
Copy link
Member

Closes #71

@alexrudd2
Copy link
Member Author

alexrudd2 commented Jun 23, 2023 •
edited
Loading

Deployed on lab_ovens; it appears to work.
Also works deployed on c3_membrane.
EGR was the one that breaks; it works on my local machine but I didn't deploy.

@alexrudd2 alexrudd2 changed the title Fix KeyError Fix KeyError when reading > 124 modbus tags Jun 28, 2023
@alexrudd2 alexrudd2 merged commit 692be7c into master Jun 28, 2023
19 checks passed
@alexrudd2 alexrudd2 deleted the issue71 branch June 28, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KeyError breaks reads with > 124 modbus tags
1 participant
@alexrudd2