Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lock from _connect #76

Closed
wants to merge 12 commits into from
Closed

Remove lock from _connect #76

wants to merge 12 commits into from

Conversation

juli4nb4dillo
Copy link
Member

@juli4nb4dillo juli4nb4dillo commented Aug 8, 2023

  • Lock on _connect seems to be redundant, since _request already awaits the connectTask.
  • Bubble up TimeOut and Connection exceptions as different exceptions, so they can dealt with the container separately (ignore, or remake a connection).

@alexrudd2
Copy link
Member

I think it should be fine to remove the lock, but since it's not causing any problems, I want to iron out the disconnect issue first before making another change. Therefore, moving this to draft.

@alexrudd2 alexrudd2 marked this pull request as draft August 18, 2023 15:23
@alexrudd2
Copy link
Member

I've split out removing the lock into #80, in order to land it separately.

The debugging/exception stuff belongs in #75

@alexrudd2 alexrudd2 closed this Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants