GTK 3.20 :: Menu code minimal optimalization #547
Conversation
|
@khurshid-alam You should be modified? |
|
Ok. |
|
@megax I think there is not enough padding in your screenshot 😬 |
|
@lots0logs Which direction? :D |
|
Mostly top/bottom but also the left padding on the first item |
|
Adjust to your taste :) |
|
@lots0logs Not to much, please :) |
|
@khurshid-alam, @lots0logs Change? Do you have any idea? |
megax
changed the title
|
@khurshid-alam Remove unused code: Before: After: |
|
@megax We need to discuss all these "optimizations" you are proposing because basically what they amount to is removing padding every where. I don't like it at all. I don't even use Numix anymore because it no longer looks good. I cant help but wonder why maintain something I don't even use because I dislike it? 🤔 |
|
@lots0logs First and foremost, I would like to apologize for my short and sometimes confusing descriptions. The English language is a big obstacle, I can understand it but I cannot create an answer. Now, I am writing to you with aid, so you can understand. Like every other user, I started using the theme around 2-3 years ago because it was stable (balanced?) . There weren't any unnecessary padding, the color balance were right, etc. I still like the old colors, that is why I tend to make everything smaller, but its a different matter. I know what you like, I understand, but like everyone else, I tend to choose the old over the new.( I will attach old pictures.) I understand your point. I respect it, I don't want to force only my ideas. If needed I will change the form as you asked and create another version with my solutions. But we should decide what we will keep from the old theme and what we would like to label as new. I were against the little buttons at first, i think that could be 18px eg. , but this is right as well. I remember there were some argument around this too So the main point is, Write down what you, @khurshid-alam and @satya164 want me to focus and tend to on the visual appearance and I will send changes and repairs according to it I don't want trouble and disaggreement due my liking to the whole them, it should be optimized to your liking(It will be good looking anyway) or it should be in the old classic. ofcourse for smaller buttons and headbar should be smaller interval should do, right?
|
|
@megax Thanks for the detailed response. I am not able to read it at this moment (very busy with work right now) but I will come back to it as soon as I can (which should be later this evening). |
|
One thing I like to clarify that usually people with 1366x768 complains (on forums, G+ etc) about being less spacious compared to 3.18. I myself at 1920 × 1080 on 13.6'' display, so I don't really see the problem but others do. I usually ignore those requests and even closed many bugs here. But as 1366x768 is still most common resolution it is sensible that we should consider to support it. Beside X doesn't really support hidpi+ either. That is why people use scale factor on hidpi display even for Adwaita. Upto 3.18 everyone is using tools like oomox (https://github.com/actionless/oomox) to change global variable like $spcing to deal with padding issue. But since 3.20 oomox is broken and oomox dev (and the from Ubuntu studio) both email me about the problem. $spacing can not be changed due to asymmetrical padding...So my intention is to use symmetrical padding throughout the code.....I know it doesn't happen in one day....I believe optimization is the continuous process during which we may increase/decrease certain elements but it's for getting better I guess. |
|
Ah still very busy at the moment, but wanted to say this now before I forget. Symmetrical margin/padding will not make sense in all situations. Everything would be square if that was the case. I get your point, but just wanted to mention that its not so black/white. |
Optimized: e86ef11
(Sorry =/, now perfect!)
Before:
After:
