[T10-1] Task Scheduler #106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunpengn
approved these changes
Oct 4, 2018
yunpengn
approved these changes
Oct 8, 2018
There was a problem hiding this comment.
Glad to see that you have fixed the errors arising from check styles. Good job! Please try to fix the errors from test as well.
seedu.address.storage.JsonUserPrefsStorageTest > readUserPrefs_fileInOrder_successfullyRead FAILED java.lang.AssertionError at JsonUserPrefsStorageTest.java:65
seedu.address.storage.JsonUserPrefsStorageTest > readUserPrefs_extraValuesInFile_extraValuesIgnored FAILED java.lang.AssertionError at JsonUserPrefsStorageTest.java:79
Hope to see contributions from all team members.
yunpengn
approved these changes
Oct 15, 2018
yunpengn
approved these changes
Oct 20, 2018
yunpengn
approved these changes
Oct 28, 2018
Change implementation of To Do List Commands in Logic
two test cases in ShowDescriptionCommandTest cannot pass
Add Agenda to README libraries used
* Docs: fix tag error
Update Docs
Update Dev Guide.
change personUtil -> calendareventUtil
manual testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bryanwongweiheng @SleepySanjinLi @vig42 @pangjiahao