[T09-3] Picconso #50
[T09-3] Picconso #50
Conversation
There was a problem hiding this comment.
Just a brief look through. Great work so far.
Some things to note though,
- usually user guide should match the current product, so if its not yet implemented, do mark it with a
(future feature)or something. - You can remove the top navigation bar too as it doesn't fit your product nicely.
Keep up the good work towards v1.1
| ifdef::env-github,env-browser[:relfileprefix: docs/] | ||
|
|
||
| https://travis-ci.org/se-edu/addressbook-level4[image:https://travis-ci.org/se-edu/addressbook-level4.svg?branch=master[Build Status]] |
There was a problem hiding this comment.
instead of removing, you can update them with your own repo link
docs/AboutUs.adoc
Outdated
| {empty}[http://www.comp.nus.edu.sg/~damithch[homepage]] [https://github.com/damithc[github]] [<<johndoe#, portfolio>>] | ||
| === Jeffry Lum | ||
| image::jeffry.jpg[width="150", align="left"] | ||
| {empty}[https://github.com/j-lum[github]] [<<jeffry#, portfolio>>] | ||
|
|
||
| Role: Project Advisor |
docs/DeveloperGuide.adoc
Outdated
| * has a need to manage a significant number of contacts | ||
| * prefer desktop apps over other types | ||
| * can type fast | ||
| * needs a qiocl amd easy way to edit images |
There was a problem hiding this comment.
Good work, code quality wise seems to be good. Some things, however, need to be updated soon. E.g. restore your Travis CI.
Other things:
-
Landing page
- url needs to be updated
- url needs to be updated
-
Gh-pages
- Update/remove to match your product:
- Update/remove to match your product:
-
README
- Mock-up looks good
-
User-guide
- looks good
- features not implemented yet should be clearly marked as Coming in v2.0
-
Developer guide
- You can remove Appendix A and G if you want
- {More to be added} can be removed if no longer applicable
Use case: Editing an imagewheres the app's interaction?- Your NFR is a bit closely tied to the features. Perhaps can add a few more generic ones.
- Still a lot of
AddressBookreferences, which should be refactor or removed.
| * Constructor for ChangeImageEvent | ||
| * | ||
| * @param image Image to replace | ||
| * @param target The name of the ImageView to target. |
There was a problem hiding this comment.
Can probably name the variables to be more intuitive so that you don't have to further explain?
| public final String target; | ||
|
|
||
| /** | ||
| * Constructor for ChangeImageEvent |
There was a problem hiding this comment.
this can be omit as its self explanatory.
|
|
||
| private ArrayList<Layer> layers = new ArrayList<>(); | ||
|
|
||
| public Canvas(Image base){ |
| //@@author chivent | ||
|
|
||
| /** | ||
| * Google Client Instance |
There was a problem hiding this comment.
need to provide more detail e.g. what is it for.
Update Appveyor and Coveralls badges on Readme
Edit Photo class
|
@chivent @j-lum @ihwk1996 @lancelotwillow @benedictcss Feedback for v1.2Please refer to my v1.1 comments for some of the things that you might have missed out. Photos
Developer Guide
Overall
|
…aster Merge pull request nus-cs2103-AY1819S1#50 from weiqing-nic/new
Add a Codacy badge to README.adoc
Add a Codacy badge to README.adoc
# Conflicts: # src/main/java/seedu/address/logic/commands/ConvertCommand.java # src/main/java/seedu/address/logic/commands/ExampleCommand.java
# Conflicts: # src/main/java/seedu/address/logic/commands/ConvertCommand.java # src/main/java/seedu/address/logic/commands/ExampleCommand.java
!!!Breaking changes multiple features!!!
!!!Breaking changes multiple features!!!
Update ugdg
add manual test
Updated the DG to include a testing guide.
update manual testing of undo redo
…into general-updates # Conflicts: # docs/DeveloperGuide.adoc
General updates
Pants wetting exception fixing experience.
Please figure out how to write tests.
Change the percentage in resize to match code. Reminded users that layer and canvas operations are in fact **NOT** transformations. Change `layer remove` to `layer delete`. Added notice that positions will not take anything longer than a int. Copied tutorial images out so that help will display them.
removal of auto-login
@chivent @j-lum @ihwk1996 @lancelotwillow @benedictcss