[W17-1] ResuMaker #76
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull from Group Repo
There was a problem hiding this comment.
Good work for setting up the repo and making the PR.
However, your User Guide (features) and Developer Guide (user stories, use cases, NFRs, target profile etc.) changes are not reflected. So, do those ASAP.
Also, update the links in the README and remove the Learning Outcomes section as it is not relevant to your product.
Work towards completing the tasks necessary for the v1.1 milestone.
On a side note, remember to keep updating your individual portfolios as you progress. Otherwise, you'll have to fill in the entire document at one go.
DO NOT close this PR.
| @@ -15,13 +16,8 @@ ifndef::env-github[] | |||
| image::images/Ui.png[width="600"] | |||
There was a problem hiding this comment.
Try to update this image with a UI mockup of your final product.
docs/AboutUs.adoc
Outdated
|
|
||
| Role: SoC Awareness |
There was a problem hiding this comment.
Try to allocate the different components of the codebase amongst your team members as well.
docs/AboutUs.adoc
Outdated
|
|
||
| Role: SoC Awareness |
There was a problem hiding this comment.
Also, it would be good to assign a person to be Team Lead
…umentation * Acknowledge the SE-EDU team * Remove word "sample" * Remove Learning Outcomes link * Update link to issue tracker * Add horizontal rule * Add line break * Update title, target users, value proposition * Added User Stories * Add Glossary, Non Functional Reqs * Update Introduction, link to Repo * Add SoC awareness Use Cases * Removed trailing whitespace * Removed trailing whitespace * Update team name, link to Repo * Removed trailing whitespace * Added SoC / NUS feature * Added SoC / NUS feature
* Remove comments * Correct wrong method call * Make StorageManager listen for EntryBookChangedEvent * Make status bar reflect EntryBook being updated
* Add getters/setters in LoadTemplateCommand for test * Add tests for LoadTemplateCommand * Add tests for LoadTemplateCommandParser * Add test for loadtemplate() in AddressBookParserTest * Fix checkstyle * Fix checkstyle
* EntryDescription: add functionality to check for existence of a bullet * AddBulletCommand: refactor event posting and checking for duplicate bullets * AddBulletCommandTest: update relevant tests * Fix checkstyletest * EntryDescription: use contains method of List * Modify MESSAGE_ADDBULLET_DUPLICATE_BULLET * Refactor EntryBook#addEnty * remove "to be modified" comment for ModelManager#hasEntry()
* Add method to check for trailing whitespace * Add method to check for single word * Update string util test * Add assertions, abstract out string processing * Add line break * Remove ws * Remove unused import * Add filter to prevent redundant additions * Update javadoc * Improve style in test * Reorder import * Add negative test * Fix empty string bug * Fix empty string bug * Add empty string test * Add empty string test * Renaming string util method * Reorder import
…ed tests (se-edu#324) * Remove deprecated constructor * Move file to subpackage * Remove unused import * Update awareness tests * Update parsing for awareness observer * Update awareness service test * Update message to user * Change regex access modifier * Rename variables
|
👍 |
* Changed UI column headings * Make ExpandedEntry display using labels rather than only one TextArea * Add spacing between category and other tags * Standardize spacing for headers/columns * Changed CSS * Make template show filepath in UI heading * Make Model retain current template if load failed * Modify UI * Modify UI screenshot * Fix checkstyle * Fix test * Remove extra line
* removed data encryption example * add code snipplet to examples * update img link & adds code example to mkPredicate * wip for ppp * ppp done * updated pr # * update ext prs * standardization on pr quoting * added clarification for diagrams
* Update "Coming in v1.4" * Moving v2.0 features to the bottom * Minor correction * UG: PPP to only include features completed to be tagged
* Further update to sequence diagram * Developer Guide: remove Suggested Programming Tasks to Get Started section
… tests (se-edu#317) * Construct Awareness after loading * Remove obsolete comment * Trigger loading in MainApp * Create constant specifying awareness filepath * Use constant filepath * Remove mass import * Import xml awareness storage * Remove final modifier (redundant) * Remove newline * Add test for XmlAwarenessStorage * Remove trailing ws * Add test file * Add test
* made minor changes to ug * remove whitespace
* Title case correction * Add purpose of PPP * Modify Overview * Complete Major Enhancement * Add PRs for Major Contribution * Update other contributions * Add flow diagram for Entry Management commands * Debug * add break line between segments * Fine-tune Language * adding Overview * update flow diagram * Add numbering to headers
* Make TemplateStorage passed in to StorageManager rather than instantiated inside * Add template test text files * Add template storage tests * Fix checkstyle * Modify tests, fix checkstyle * Make slight changes to Template and rename variables * Change filepath to filePath * Fix template storage test * Add newline to EOF
* Improve portfolio * Add design consideration * Add diagrams * Add extension diagram * Improve PPP * Add diagram * Add sections to user guide * Update PPP formatting and add diagram * Add code snippet * Add test code snippet * Modify PPP formatting
* temp tests * Change equals() state checks * Add testing utility subclass of ModelManager * Add tests for resume classes * Complete resume storage tests * Finish tests for make command * Fix markdown conversion test * Clean imports * Fix style * Add empty constructor * Change constructor to private
* Update template docs and PPP * Update PPP
* Update context dg, add activity diagram * Update dg * Update design choice * Add image * Update dg * Add newline * Remove trailing ws * Update ppp * Remove ws * Add data config info * Add data config info
* Update DG * update ppp * Update ppp
* Add sample entries * Remove ws
* Update template UG/DG * Resolve conflicts * Add manual testing instructions * Update storage diagram * Add tip to command format
* Fix command strings * Fix style
* Update template UG/DG * Resolve conflicts * Add manual testing instructions * Update storage diagram * Add tip to command format * Update docs
* Update docs * Update docs for web version * Add newline to EOF
* remove from model * removed xml addr book data test * rm cmd & parser from logic * update and replace main command parser * refactor logic stuff * fix storage * ui comps, fixes se-edu#306 * update evts & ui * update indentation style * updated system test * updated storage test * update model test * rm test for cmd and parser * rm sys test for logic * update sys test again * rm from cmd * ui test changes * rm ab4 logic tests * rm base sys test * sys and gui test rmv * first stage done, oh my gawd, huge ragrats * removed unused import, now i know why ppl create ide :( * fix null pointer error * pass history test * use existing func in logic manager test * rm fxml * fake the entrybook storage path * ha lai lu ya, it works guys it works * update storage to use entrybook stuff * fix main checkstyle * fix test checkstyle * fix assertNotNull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@anubh-v @ongspxm @scalarmotion @marvintxd