[Seng Zhen Hong] iP #468
[Seng Zhen Hong] iP #468
Conversation
Let's tweak the docs/README.md (which is used as the user guide) to fit Duke better. Specifically, 1. mention product name in the title 2. mention adding a product screenshot and a product intro 3. tweak the flow to describe feature-by-feature
src/main/java/Duke.java
Outdated
| while (!command.equals("bye")) { | ||
| System.out.println("____________________________________________________________"); | ||
| try { | ||
| if (command.equals("list")) { |
There was a problem hiding this comment.
The code seems to be too long for me. Try to divide each commands into different functions.
src/main/java/Duke.java
Outdated
| LocalTime endTime = LocalTime.parse(to, DateTimeFormatter.ofPattern("HHmm")); | ||
| return new EventTask(description, startTime, endTime); | ||
| default: | ||
| return new ToDoTask(description); |
There was a problem hiding this comment.
Consider the case when the file is corrupted
src/main/java/Duke.java
Outdated
|
|
||
| class Task { | ||
| protected String description; | ||
| protected boolean isDone; |
src/main/java/Duke.java
Outdated
| } | ||
| duke.saveTasksToFile(tasks); | ||
|
|
||
| System.out.println("____________________________________________________________"); |
There was a problem hiding this comment.
Maybe consider connecting this three println statements using +.
src/main/java/Duke.java
Outdated
| @@ -1,10 +1,283 @@ | |||
| import java.io.File; | |||
There was a problem hiding this comment.
Can consider ordering imports in lexical order
src/main/java/Duke.java
Outdated
| System.out.println("Hello from\n" + logo); | ||
| System.out.println("____________________________________________________________"); |
There was a problem hiding this comment.
Can consider making linebreaks into a constant variable which can make code cleaner
src/main/java/Duke.java
Outdated
| String command = scanner.nextLine(); | ||
| // Initialize tasks list here | ||
|
|
||
| while (!command.equals("bye")) { |
There was a problem hiding this comment.
Can consider breaking down this function into smaller functions to make it more readable for others, might be a little too long currently. Can break down into like two functions like run and commands
src/main/java/Duke.java
Outdated
| scanner.close(); | ||
| } | ||
| } catch (IOException e) { | ||
| System.out.println("Error loading tasks from file: " + e.getMessage()); |
There was a problem hiding this comment.
Can consider making this into your own exception class and include the additional error messages as part of the new exception
src/main/java/Duke.java
Outdated
| protected boolean isDone; | ||
|
|
||
| public Task(String description) { | ||
| this.description = description; |
There was a problem hiding this comment.
Is there a reason why you added this. infront in task and not in Duke class? Can consider having a constant reference standard.
src/main/java/Duke.java
Outdated
There was a problem hiding this comment.
Good naming of functions and variables and all in all LGTM but just some minor nits
This commit adds an assertion to the parseCommand method in the Parser class to ensure that the array 'parts' has at least one element before further processing. The added assertion enhances the robustness of the code by catching unexpected conditions early in development. Changes made in this commit: - Added assertion 'assert parts.length > 0;' to validate the length of the array 'parts'. This assertion serves as a safeguard against potential runtime errors and improves the overall reliability of the command parsing logic.
Add assertion to ensure non-empty array in parseCommand method
Improved code quality
CharmBot
“Your mind is for having ideas, not holding them.” – David Allen (source)
DukePro frees your mind of having to remember things you need to do. It's,
text-based
easy to learn
FAST SUPER FAST to use
All you need to do is,
add your tasks.
let it manage your tasks for you 😉
And it is FREE!
Features:
Managing tasks
Managing deadlines (coming soon)
Reminders (coming soon)