Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CS2103-F09-3] TutorRec #119

Open
wants to merge 364 commits into
base: master
Choose a base branch
from

Conversation

Darylgolden
Copy link

TutorRec is a CLI-based app that helps Peter manage information about his clients easily, assisting him with scheduling and administration.

Copy link

codecov bot commented Mar 3, 2024

Codecov Report

Attention: Patch coverage is 81.68044% with 133 lines in your changes are missing coverage. Please review.

Project coverage is 78.36%. Comparing base (b896eb0) to head (55db5c9).

❗ Current head 55db5c9 differs from pull request most recent head de6f211. Consider uploading reports for the commit de6f211 to get more accurate results

Files Patch % Lines
...c/main/java/seedu/address/model/person/Person.java 75.00% 2 Missing and 15 partials ⚠️
src/main/java/seedu/address/model/AddressBook.java 65.11% 11 Missing and 4 partials ⚠️
...ess/model/appointment/DisjointAppointmentList.java 64.10% 14 Missing ⚠️
src/main/java/seedu/address/ui/PersonCard.java 0.00% 14 Missing ⚠️
.../java/seedu/address/model/util/SampleDataUtil.java 33.33% 12 Missing ⚠️
...java/seedu/address/logic/commands/EditCommand.java 78.72% 2 Missing and 8 partials ⚠️
...a/seedu/address/model/appointment/Appointment.java 77.77% 8 Missing and 2 partials ⚠️
...u/address/storage/JsonSerializableAddressBook.java 69.23% 4 Missing and 4 partials ⚠️
...in/java/seedu/address/model/person/EmptyLevel.java 44.44% 3 Missing and 2 partials ⚠️
src/main/java/seedu/address/logic/Messages.java 75.00% 0 Missing and 4 partials ⚠️
... and 9 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #119      +/-   ##
============================================
+ Coverage     75.26%   78.36%   +3.09%     
- Complexity      419      662     +243     
============================================
  Files            71       95      +24     
  Lines          1338     2135     +797     
  Branches        126      252     +126     
============================================
+ Hits           1007     1673     +666     
- Misses          301      376      +75     
- Partials         30       86      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

JonChong98 and others added 29 commits March 20, 2024 22:11
Component section of the Developer Guide to include Appointment and Note
classes

Previous PR merges have added functionality for Appointment and Note but
did not update the corresponding UML diagrams in the Developer Guide.
This PR make these updates to the Model Component section of the
Developer Guide.
…agram

Update BetterModelClassDiagram and ModelCLassDiagram in the Model Component section of the Developer Guide
Updated the DG to include the UML sequence
diagram for the 'list' command.
Fixed a minor bug relating to newlines
for the 'list' UML diagram.
Update UML class diagram and Developer Guide for Ui component
Add UML diagram for managing appointments
Currently, TutorRec does not support
the editing of notes for each person.

Let's edit some classes to support
editing of notes.
Previously, TutorRec does not check for
similar names. John Doe and john doe are
both accepted.

This change involves detecting for similar
names like johndoe and JoHn dOE and
warning to user of potential similar contacts.

Note this commit does not pass the builds
and fails some testcases.
Changed the order of the example
usage message to match user guide.
Fixed a minor issue causing a test to fail.

The code is able to build and run. May need some extra test cases.

While the function itself works just fine,
not sure if the implementation is done correctly.

One last commit needed to check if all changes are up
to coding standards.
Update version number for trial jar release
Update build.gradle to enable assertions
tanqinyong and others added 30 commits April 14, 2024 10:03
Updated the UG to include ... for appointments as it
was forgotten.

Also updated the command summary at the bottom
Replace #8 planned enhancement accordingly.
…yong/tp into UG-multiple-arguments-fix

# Conflicts:
#	docs/UserGuide.md
Updated both DG and UG to include justification
of why we accept contacts with the same emails and phone numbers.
Update DG and UG to include justification
permittance of multiple argument input for `nt/` and `l/` in the edit
command

TutorRec v1.4 is referenced here.
Update UG to reflect multiple arguments behavior
Update User Guide and Developer Guide
document the behaviour of adding appointments
Improve the developer guide to document to behaviour of adding appointments
Remove unused text from Developer Guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants