Avengers Assemble #126
Open
Avengers Assemble #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #126 +/- ##
============================================
+ Coverage 75.26% 80.23% +4.96%
- Complexity 419 873 +454
============================================
Files 71 106 +35
Lines 1338 2595 +1257
Branches 126 299 +173
============================================
+ Hits 1007 2082 +1075
- Misses 301 431 +130
- Partials 30 82 +52 ☔ View full report in Codecov by Sentry. |
Now the checkstyle is fixed. Lets adhere to checkstyle.
Now tests should pass on gradle checks. Lets help gradle pass.
Now code adheres to checkstyle. lets adhere to checkstyle.
Currently, the name accepts alphanumerical characters, spaces, and forward slashes. This will allow the majority of names to be added into the app. However, it has come to light that there are names which would contain other characters that would throw errors if users attempt to add these names in, which is problematic since some special characters like `.` and `,` are common. Let's allow several other characters in the regex for names. In doing so, we can ensure that most common names will be successfully added into the application.
Fix: remove pop up window for help command
Bug fix: Update name param to include more characters
Update UG for help command
Now version is updated Lets update version.
Build: update version number
* 'master' of https://github.com/AY2324S2-CS2103T-T10-1/tp: Build: update version number Update image for help command Update chars accepted by Name Fix: checkstyle Fix: headless environment for gradle Style: fix checkstyle Fix: remove pop up window for help command
* master: (34 commits) Build: update version number Update image for help command Update chars accepted by Name Fix: checkstyle Fix: headless environment for gradle Style: fix checkstyle Fix: remove pop up window for help command Fix naming in javaDoc Fix spelling errors Small changes to test cases Comprehensive testing for `CsvUtil` and `ImportCommand` Replace references of AB3 with AA CsvUtil now throws an IOException for the case when a file is not found in the system Update examples to match images Update images to match success msg Fix: remove magic literal in unit test for import Fix: typos in success messages Satisfy github CI Satisfy Github CI Satisfy github CI actions ...
fix: add page breaks to ensure good formatting of printed user guide
…into branch_UpdateDeveloperGuide2.0
Currently, the find command holds a predicate, and creates another predicate based on whether exam scores are needed. However, this may be messy due to the fact that the predicate objects are created in different places despite serving the same purpose. Let's refactor the creation of the predicate objects to ensure that the objects follow a more logical and organized flow. In doing so, the code is both more readable and scalable.
Currently, the application throws a NullPointerException when items in the Exam List and the Person List are clicked on in the User Interface. This is due to bad implementation practices, as I had put a band aid on this problem by setting the selectionModel of both lists to null to prevent the selection of exams in the list.. While this implementation does not affect the use of the application, Lets update the implementation to use a proper "NoSelectionModel". This will prevent further NullPointerExceptions from being thrown in the application.
Currently, we were able to observe from the PE dry run that there is a possibility for testers to perceive from the UG and the error messages that there may be bugs present despite the code working as intended. This is an issue because it indicates that the documentation is not clear enough to convey the exact reason behind the current behavior of the code (e.g. semicolons after each copied email after using the `copy` command, "seemingly valid" emails being rejected). Let's ramp up the clarity in both the UG and constraint messages pertaining emails. In doing so, future users will have a much clearer idea of how the code is supposed to behave, and will not mistake correct behaviors as bugs.
Update colour scheme
Small changes to manual testing
Currently, a mix of British english and US english is used in the DG. Furthermore, some spelling errors have been spotted in both the DG and UG. We should standardize our language use to US english since the standard convention uses US english. Furthermore, we should minimize errors to uphold a high standard of professionalism. Let's fix these language issues. By doing so, we can be assured that our documentation is top notch.
…into branch_UpdateDeveloperGuide6.0
Add line breaks for DG export
docs: minor changes to UG and DG
Now the page breaks are nicely broken. Broken links are removed. List now has command and link to UG. Lets release a single and good final release.
Now the page breaks are in their original form to prevent further mistakes in formatting. Lets improve documentation
Now changes are reverted correctly. Only content errors are fixed. Lets improve documentation.
Update user stories to html tables
Final dg content changes
Format Html Tables for UG and DG
kaiyi27
pushed a commit
to kaiyi27/tp
that referenced
this pull request
Apr 13, 2024
Update user guide
Fix: Score Statistics in DG
A minor formatting error was spotted. This was because markdown notation was used when HTML notation should have been used instead. Let's fix this. By doing so, we can eliminate this minor issue.
Minor Change to DG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avengers Assemble is a contact management app, meant for use with a Command Line Interface (CLI) while still maintaining the benefits of a Graphical User Interface (GUI).
The application is designed for Head Tutors of the CS1101S Programming Methodology course but its use cases can be extended to Head Tutors of other courses.